Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a splash screen #1008

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Add a splash screen #1008

merged 1 commit into from
Jul 3, 2020

Conversation

di72nn
Copy link
Member

@di72nn di72nn commented Jun 25, 2020

That white startup screen is starting to get to me.

I don't think startup time is going to be improved anytime soon, so here's a splash screen.

To the best of my knowledge it cannot be made light or dark according to in-app theme (because splash screen theme is applied before any app code is executed). So I made it dark, because a dark screen is okay in light environment, but a light screen is annoying in the dark.

@tcitworld tcitworld merged commit 7b5d9a3 into master Jul 3, 2020
@tcitworld tcitworld deleted the splash_screen branch July 3, 2020 08:53
@Strubbl
Copy link
Contributor

Strubbl commented Jul 15, 2020

Is it possible to get a splash screen when resuming the app? Sometimes , when resuming is not that fast, I still get a white fullscreen.

@di72nn
Copy link
Member Author

di72nn commented Jul 16, 2020

What activity do you resume to?
You can check method 1 vs method 2 here.
We probably need to create an issue for discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants