Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tts: try to fix issue #735 by creating a notification channel #741

Merged
merged 2 commits into from
Feb 12, 2019
Merged

tts: try to fix issue #735 by creating a notification channel #741

merged 2 commits into from
Feb 12, 2019

Conversation

tyndare
Copy link
Contributor

@tyndare tyndare commented Oct 20, 2018

Try to fix issue #735
Update for Android >= 8.1

  • create a notification channel, and use its id to send notifications
  • create an audio focus request object

@tyndare
tts: fix issue wallabag#735: create notification channel
4ba91da 
Update for Android >= 8.1
 - create a notification channel, and use its id to send notifications
 - create an audio focus request object
@tyndare
tts: avoid NPE when calling abandonAudioFocusRequest
b215dbe
@tyndare tyndare mentioned this pull request Jan 28, 2019
Closed
@Strubbl
Copy link
Contributor

Strubbl commented Feb 12, 2019 •
edited

Hello @tyndare , thanks a lot for this PR. I can confirm, that is PR also fixes the issue #760

@Strubbl Strubbl merged commit 97e7fd8 into wallabag:master Feb 12, 2019
@Strubbl Strubbl added this to the 2.1.1 milestone Feb 12, 2019
@Strubbl Strubbl modified the milestones: 2.1.1, 2.2.0 Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Strubbl Strubbl Strubbl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tyndare @Strubbl