New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nginx.conf for reverse-proxy with HTTPS #265
Fix nginx.conf for reverse-proxy with HTTPS #265
Conversation
This fixed some of my issues when putting this Docker container behind a reverse proxy, but Wallabag is still mangling URLs (e.g. dropping port number for no reason) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested those changes in my setup where I run Wallabag+MariaDB behind Traefik v2 and they solved the problem I had (https://mywallabag.com
redirecting to http://mywallabag.com/login
instead of the https one).
I didn't experienced any issue with those changes.
I think the PR should be merged.
@j0k3r could you include this in the next release? |
I don't know how GitHub PR automation works but it seems they need 1 more approved review to proceed with merging. I already did it, maybe someone else could try to do it too? |
I got HTTP redirection loop like this |
I can confirm, this fix worked. Pls bring this PR into main |
@Kdecherf could you merge? |
@wallabag/core could you merge? This PR is really important to make Reverse Proxies to work. It's tested by me. |
dee5a95
to
bf0102e
Compare
Related #77, #264.
This PR changes the
nginx.conf
of wallabag-docker to enable fastcgi HTTPS especially in case of reverse-proxy settings.The idea is came from @blopware 's workaround and https://serverfault.com/a/527809.