Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nginx.conf for reverse-proxy with HTTPS #265

Merged

Conversation

hwiorn
Copy link
Contributor

@hwiorn hwiorn commented May 22, 2021

Related #77, #264.

This PR changes the nginx.conf of wallabag-docker to enable fastcgi HTTPS especially in case of reverse-proxy settings.

The idea is came from @blopware 's workaround and https://serverfault.com/a/527809.

@ngosang
Copy link
Contributor

ngosang commented Aug 29, 2021

@Kdecherf @j0k3r I tested this PR and I confirm it fixes #77
Tested several scenarios:

  • Direct connection to Wallabag Docker (HTTP) => OK
  • Traefik (HTTPS reverse proxy) => Wallabag Docker (HTTP) => OK

There are several issues in wallabag android app caused by #77 that will be fixed too.

@Hodapp87
Copy link

Hodapp87 commented Sep 7, 2021

This fixed some of my issues when putting this Docker container behind a reverse proxy, but Wallabag is still mangling URLs (e.g. dropping port number for no reason)

Copy link

@LeonardoMantovani LeonardoMantovani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested those changes in my setup where I run Wallabag+MariaDB behind Traefik v2 and they solved the problem I had (https://mywallabag.com redirecting to http://mywallabag.com/login instead of the https one).
I didn't experienced any issue with those changes.
I think the PR should be merged.

@ngosang
Copy link
Contributor

ngosang commented Jul 27, 2022

@j0k3r could you include this in the next release?

@LeonardoMantovani
Copy link

I don't know how GitHub PR automation works but it seems they need 1 more approved review to proceed with merging. I already did it, maybe someone else could try to do it too?

@Cycatz
Copy link

Cycatz commented Oct 10, 2022

I got HTTP redirection loop like this
https://mydomain/ -> http://mydomain/login -> https://mydomain/
This caused the Unknown error: Too many follow-up requests: 21 error on Android app upon login
This fixed the redirect issue with nginx->podman container setup and I hope this to be merged

@GeorgFoc
Copy link

I can confirm, this fix worked. Pls bring this PR into main

@ngosang
Copy link
Contributor

ngosang commented Oct 26, 2022

@Kdecherf could you merge?

@ngosang
Copy link
Contributor

ngosang commented Oct 28, 2022

@wallabag/core could you merge? This PR is really important to make Reverse Proxies to work. It's tested by me.

@j0k3r j0k3r force-pushed the fix-nginx-conf-for-reverse-proxy-with-https branch from dee5a95 to bf0102e Compare October 28, 2022 12:01
@j0k3r j0k3r merged commit 695212d into wallabag:master Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants