Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Since the last update to v5. Adding URL often doesn't work. #258

Closed
mrtpcet opened this issue Mar 11, 2020 · 22 comments
Closed

Since the last update to v5. Adding URL often doesn't work. #258

mrtpcet opened this issue Mar 11, 2020 · 22 comments
Labels
Bug Needs more information

Comments

@mrtpcet
Copy link

mrtpcet commented Mar 11, 2020

| iPhone 6s
| iOS 13.3.1
| App Version : 5.0.0
| Wallabag server version: 2.3.8

Since the last update to v5. Adding URL often doesn't work.

As soon as I want to share a url to the wallabag application, the icon appears on the screen but does not go away.
I have to copy the address, open the application and add it manually.
However, it doesn't work. The sync wheel. I have to force restart app: sometimes my url has been saved and sometimes not.
@bourvill
Copy link
Member

I have the impression that there are problems with the authentication of your application.

Are you self-hosted?

@bourvill bourvill added the Bug label Mar 12, 2020
@mrtpcet
Copy link
Author

mrtpcet commented Mar 12, 2020

Yes I am, an installation with Yunohost.

@bourvill
Copy link
Member

Hello, on your instance? Can you create an account for me on your instance?

@mrtpcet
Copy link
Author

mrtpcet commented Mar 19, 2020

Hello, on your instance? Can you create an account for me on your instance?

Hello. Of course. Here you user id: https://privatebin.net/?91c758c5e3d7e4b9#GsgxAzQ5k6ev6kxg7T3eXvjSkGXxFJFuTuhJfo34cFpE (the note is destroyed after the first reading)

@bourvill
Copy link
Member

I can't reproduce your problem.
I'm using your instance.
The workflow of adding from the app is not finished, completed. I will work on it so that the addition to the list is immediate without having to redo a synchronization.

When you try to add a URL, do you have a good internet connection?

Sorry for all these stupid questions, but I really don't have a clue to reproduce the problem

@mrtpcet
Copy link
Author

mrtpcet commented Mar 22, 2020 •
edited

When you try to add a URL, do you have a good internet connection?
Yes, my very good Home connexion.

Honestly, since the past day, the bug is pretty less present. Two times, when I past directly an url in the app, I was forced to kill the app and reopen it to show the link appeared.
I don’t really understand ..
Maybe my mobile vpn ? (Proton vpn) or my dns ad guard ? (Privacy Pro).

bourvill added a commit that referenced this issue Mar 22, 2020
@bourvill
Better workflow for adding url in apps ref #258
f8f773e
@bourvill bourvill added this to the 5.0.1 milestone Mar 23, 2020
bourvill added a commit that referenced this issue Apr 6, 2020
@bourvill
Release 5.0.1 (#260)
4df1c3f 
* Clean repo and prepare 5.0.1

* Hide header during registration

* Arrange registration process,
clean class,
better url check
automatic trimming clientId & clientSecret

* Reintroduce tests using github actions

* Add test and fix memory leaks

* Add test and fix memory leak

* Add more test

* Polish sync

* Better workflow for adding url in apps ref #258

* Fix #252 slide menu

* Build using Xcode 11.4
Disable pecker (not working actually)

* Update swift-version

* Enable second view

* Fix logout issue

* Fix #254 Sync not push to server

* Arrange logout

* Remove old assets

* Cleaning project

* Using testplan

* Externalize logger

* Add bool on int

* Add bug report view fix #262

* first step for logging ref #261

* New build beta with bug report view

* Try to fix add tag in entry

* Fix slidding menu fix #264

* Arrange menu fix #266

* Udpate testflight link ref #118

* fix port number in address ref #257
@bourvill bourvill removed this from the 5.0.1 milestone Apr 6, 2020
@bourvill
Copy link
Member

Error is fixed with 5.0.1?

@mrtpcet
Copy link
Author

mrtpcet commented Apr 12, 2020

Regularly (1 time out of 3), when I share a link to wallabag from an application, the wallabag logo appears and stays frozen on the screen (it doesn't disappear like when it works). I have to drag the logo down and start sharing again: it usually works the second time.

@bourvill
Copy link
Member

I seem to be a connection problem. When the problem occur do you have good connection?

@mrtpcet
Copy link
Author

mrtpcet commented Apr 15, 2020

These last few weeks I am at home with a very fast fiber connection (300mb/300mb) in wifi 5Ghz.
Nevertheless, I use protonVPN as VPN and Privacy Pro as DNS server intermediary.
I will try today to disable them to see.

@mrtpcet
Copy link
Author

mrtpcet commented Apr 15, 2020 •
edited

Okay, I tried two things:

  1. Disable ProtonVPN
    => Test the share
  2. Disable Proton VPN and PrivacyPro
    => Test the share

Results: the problem appeared after about ten shares. Then, it appears regularly every 2-3 shares. Sometimes, I have to drag the logo twice and try again before the sharing works.

@bourvill
Copy link
Member

hello @mrtpcet the latest beta version incorporates a new communication mechanism with the server.
Could you take a test?

@mrtpcet
Copy link
Author

mrtpcet commented Apr 29, 2020

Okay, here we go !

@mrtpcet
Copy link
Author

mrtpcet commented May 7, 2020

I've had no problems since the last two builds (264 and 263) ;-)

@bourvill
Copy link
Member

Ok, fix is merged and app is in review by apple :)

I close this Issue :)

@timespaced
Copy link

timespaced commented May 15, 2020 •
edited

Was this issue to have been fixed in 5.0.2? Because I still have the problem. When using the “share” option from Safari (or Firefox) and pressing on Wallabag, an overlay is displayed with Wallabag logo, but nothing else, and it just freezes there. I have to swipe it down to close it.

It does appear to save the article though.

@bourvill
Copy link
Member

Can your share your url ?
If you try to add url manually from app? Do you have an error ?

@timespaced
Copy link

It happens with any URL. Here is a specific one:
https://ashadeofteal.com/rustic-diy-bookshelf-with-ikea-ekby-brackets/

Adding the URL directly in the app via “add entry” does the something similar - it says “submitting” then goes back to “submit” button after a few seconds, and the URL is still in the field. After submittal within the app I would expect the URL to be cleared and a message to say something like “added!”

Also via the Share extension within other apps (Safari) I would expect “Added!” To be shown and the wallabag icon logo to clear by itself.

It would also be good if we could add a tag to the article during both processes - via “Share” and via “add entry” in the app.

@bourvill
Copy link
Member

Do you have any issue with sync ?

@timespaced
Copy link

No issue with sync.

@bourvill bourvill reopened this May 18, 2020
@bourvill
Copy link
Member

@haltdev When you try to add url with share extension, can you check your web server instance? Article is added?

If you have access to your webserver log, can you check log access when your try to add url ?

@bourvill
Copy link
Member

Do you still have the problem since the last update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Needs more information
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bourvill @thibaultamartin @timespaced @mrtpcet