Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "send" button on config page #1299

Closed
nicosomb opened this issue Aug 8, 2015 · 5 comments
Closed

Change "send" button on config page #1299

nicosomb opened this issue Aug 8, 2015 · 5 comments
Assignees
@modos189
Labels
UI
Milestone
2.0.0-alpha.0

Comments

@nicosomb
Copy link
Member

nicosomb commented Aug 8, 2015

On config page, the button to valid the form is labelled "Send". I think we can have something better ("save", "validate", "ok", "save my preferences", etc.).

@tcitworld @j0k3r an opinion?
@nicosomb nicosomb added the UI label Aug 8, 2015
@nicosomb nicosomb added this to the 2.0 milestone Aug 8, 2015
@tcitworld
Copy link
Member

Save sounds good to me.

@nicosomb
Copy link
Member Author

nicosomb commented Aug 8, 2015

just "save"? "save my preferences" sounds better to me, but "save" is shorter, it's good too.

@modos189
Copy link
Contributor

modos189 commented Aug 8, 2015

i think
"Save" for 'Wallabag', 'RSS' and 'User information',
"Update" for 'Password',
"Add a user" for 'Add a user'

@nicosomb
Copy link
Member Author

nicosomb commented Aug 8, 2015

👍 let's go.

@nicosomb nicosomb modified the milestones: 2.0, 2.0.0-alpha Aug 12, 2015
nicosomb added a commit that referenced this issue Aug 12, 2015
@nicosomb
fix #1299: change send buttons on config page
43e6f47
j0k3r added a commit that referenced this issue Aug 12, 2015
@j0k3r
Merge pull request #1326 from wallabag/v2-fix-1299
1a0ea1f 
fix #1299: change send buttons on config page
@nicosomb
Copy link
Member Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@modos189 modos189

Labels
UI
Projects
None yet
Milestone
2.0.0-alpha.0
Development

No branches or pull requests
3 participants
@nicosomb @modos189 @tcitworld