Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display problem if domain name is too big #1357

Closed
nicosomb opened this issue Aug 17, 2015 · 4 comments
Closed

Display problem if domain name is too big #1357

nicosomb opened this issue Aug 17, 2015 · 4 comments
Assignees
@modos189
Labels
UI
Milestone
2.0.0-alpha.0

Comments

@nicosomb
Copy link
Member

Have a look
@nicosomb nicosomb added the UI label Aug 17, 2015
@nicosomb nicosomb added this to the 2.0.0-alpha.0 milestone Aug 17, 2015
@modos189
Copy link
Contributor

What kind of behavior you expect?

@nicosomb
Copy link
Member Author

I think we should truncate the URL. What do you think of that? Have a look to slice function http://twig.sensiolabs.org/doc/filters/slice.html

@modos189
Copy link
Contributor

Although... The width of the card varies with the width of the screen, I'll use CSS overflow

nicosomb added a commit that referenced this issue Aug 24, 2015
@nicosomb
fix #1357, truncate domain name if it's too loooong
50243f0
@nicosomb
Copy link
Member Author

Just opened a PR #1400.

j0k3r added a commit that referenced this issue Aug 25, 2015
@j0k3r
Merge pull request #1400 from wallabag/v2-fix-1357
c6da9be 
fix #1357, truncate domain name if it's too loooong
@j0k3r j0k3r closed this as completed Aug 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@modos189 modos189

Labels
UI
Projects
None yet
Milestone
2.0.0-alpha.0
Development

No branches or pull requests
3 participants
@j0k3r @nicosomb @modos189