Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport site config changes from wallabag v1 to fivefilters repo #1414

Closed
j0k3r opened this issue Sep 10, 2015 · 5 comments
Closed

Backport site config changes from wallabag v1 to fivefilters repo #1414

j0k3r opened this issue Sep 10, 2015 · 5 comments
Assignees
Milestone

Comments

@j0k3r
Copy link
Member

j0k3r commented Sep 10, 2015

Instead of keeping two differents repositories of site configs, it could be better to contribute to the official site config repo from @fivefilters: https://github.com/fivefilters/ftr-site-config

So we need to extract site configs from wallabag v1 (here: https://github.com/wallabag/wallabag/tree/master/inc/3rdparty/site_config/standard) and merge them in the fivefilters repo.

@j0k3r j0k3r added this to the 2.0.0-alpha.0 milestone Sep 10, 2015
@tcitworld
Copy link
Member

I think this depends if @fivefilters agrees (and is able to !) to update it fast enough when we PR it.

@j0k3r
Copy link
Member Author

j0k3r commented Sep 10, 2015

As far as I can see, he is fast enough.

@tcitworld
Copy link
Member

Yeah, it seems so. Right.

@j0k3r j0k3r modified the milestones: 2.0.0, 2.0.0-alpha.0 Sep 10, 2015
@j0k3r j0k3r self-assigned this Dec 29, 2015
@j0k3r j0k3r modified the milestones: 2.0.0-alpha.1, 2.0.0 Dec 31, 2015
j0k3r added a commit to j0k3r/graby-site-config that referenced this issue Dec 31, 2015
@nicosomb
Copy link
Member

nicosomb commented Jan 6, 2016

Is this issue needed for next alpha?

@j0k3r
Copy link
Member Author

j0k3r commented Jan 6, 2016

It's not a must have, it's a nice to have.

Le 6 janv. 2016 à 09:09, Nicolas Lœuillet notifications@github.com a écrit :

Is this issue needed for next alpha?


Reply to this email directly or view it on GitHub.

@nicosomb nicosomb modified the milestones: 2.0.0-beta.1, 2.0.0-alpha.1 Jan 8, 2016
@j0k3r j0k3r closed this as completed Feb 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants