Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When displaying domain on themes, skip the www part #1433

Closed
tcitworld opened this issue Sep 24, 2015 · 5 comments
Closed

When displaying domain on themes, skip the www part #1433

tcitworld opened this issue Sep 24, 2015 · 5 comments
Labels
Improvement UI
Milestone
2.0.0-alpha.1

Comments

@tcitworld
Copy link
Member

No one cares about it.
@tcitworld tcitworld added this to the 2.0.0 milestone Sep 24, 2015
@nicosomb
Copy link
Member

@j0k3r I think it's good to create a twig extension. What do you think about it? (we can use replace in twig, but we have to check if www. is at the beginning of the URL)

@j0k3r
Copy link
Member

j0k3r commented Sep 24, 2015

Yeah, it might be a bit overkill but could a clean solution !

@nicosomb
Copy link
Member

I made this fix {{ entry.domainName|replace({'www.': ''}) }} but imagine a domainName with www. inside ...

@nicosomb nicosomb mentioned this issue Sep 29, 2015
Merged
@nicosomb nicosomb modified the milestones: 2.0.0-alpha.1, 2.0.0 Sep 29, 2015
tcitworld added a commit that referenced this issue Sep 29, 2015
@tcitworld
Merge pull request #1440 from wallabag/v2-fix-1433
d2755b1 
fix #1433: remove www. on entries view
@nicosomb nicosomb reopened this Sep 30, 2015
@nicosomb
Copy link
Member

Tests needed.

@nicosomb
Copy link
Member

nicosomb commented Oct 6, 2015

test here #1461

j0k3r added a commit that referenced this issue Oct 6, 2015
@j0k3r
Merge pull request #1461 from wallabag/v2-test-for-www
fdef5f4 
fix #1433: add test for removeWww Twig Extension
@j0k3r j0k3r closed this as completed Oct 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement UI
Projects
None yet
Milestone
2.0.0-alpha.1
Development

No branches or pull requests
3 participants
@j0k3r @nicosomb @tcitworld