Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change databases name for mysql/pgsql in test environment #1635

Closed
nicosomb opened this issue Jan 28, 2016 · 2 comments
Closed

Change databases name for mysql/pgsql in test environment #1635

nicosomb opened this issue Jan 28, 2016 · 2 comments
Milestone
2.0.0-beta.1

Comments

@nicosomb
Copy link
Member

We defined wallabag as a name for test database. We need to change this value.

https://github.com/wallabag/wallabag/blob/v2/app/config/tests/parameters.yml.dist.mysql#L15
@nicosomb nicosomb added this to the 2.0.0-beta.1 milestone Jan 28, 2016
@j0k3r
Copy link
Member

j0k3r commented Jan 31, 2016

Why ?

@nicosomb
Copy link
Member Author

nicosomb commented Feb 1, 2016

To avoid "content conflicts" with existing database. The name is not wallabag_test but wallabag ... It will destroy my dev database.

nicosomb pushed a commit that referenced this issue Feb 1, 2016
Fix #1635: change database name for test environments (mysql/pgsql)
61c640e
@nicosomb nicosomb mentioned this issue Feb 1, 2016
Merged
j0k3r added a commit that referenced this issue Feb 1, 2016
@j0k3r
Merge pull request #1639 from wallabag/v2-change-test-dbname
74d8afa 
Fix #1635: change database name for test environments (mysql/pgsql)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0-beta.1
Development

No branches or pull requests
2 participants
@j0k3r @nicosomb