-
-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation about translation: which language file is the reference? #1692
Comments
I don't know if a tool like Transifex can help us for this problem. We already discuss about this problem on our internal chat. @wallabag/core any idea? |
Well, we should be more attentive when we add new translation and add them (with default message) to all translations. |
Let's make it less frustrating: only add translations to one file, because most of the core devs are french, let's stick to that. Next, only add new lines at the end of the paragraph, so we don't need to pick line by line to see if one line was inserted or deleted in each paragraph, each time we have a new translation.
|
I opened a new PR with the info about french translation as the reference to translate wallabag. |
Just wondering : shouldn't there be an English translation file ? Logs keep complaining of missing translations for English, it's quite frustrating when you're looking for something useful in the logs. Of course it would bring nothing, but it would be easier for foreigners to translate, starting from this file. |
We'll have english files because @j0k3r wants to change all our translation files by using keys instead of sentences (I will open a new issue for that). |
I agree too. |
Well, I would like :) |
The Persian translation #1676 was done by duplicating the German file (129 lines) and replacing German strings with Persian translations. Now I see that there are some more strings to translate in the French file (233 lines):
wallabag/src/Wallabag/CoreBundle/Resources/translations/messages.fr.yml
and the German/Persian translation of those extra strings are missing.
I suggest to mention this in the Documentation about translation that new translations should be done by first copying the French files.
Ideally, there should be an automatic way of adding those extra entries to other languages as they appear in the course of development, e.g. #1683 and #1690 .
The text was updated successfully, but these errors were encountered: