Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NPM to handle external (JS & CSS) assets #1759

Closed
j0k3r opened this issue Mar 7, 2016 · 3 comments
Closed

Use NPM to handle external (JS & CSS) assets #1759

j0k3r opened this issue Mar 7, 2016 · 3 comments
Labels
Feature
Milestone
2.1.0

Comments

@j0k3r
Copy link
Member

j0k3r commented Mar 7, 2016

Instead of copying external assets in the repo we should use NPM (and/or Bower) to retrieve them.
Here are a list of external assets we actually use:

  • prismj
  • jquery
  • jquery.cookie
  • materialize
  • annotator
  • icomoon
  • material-design-icons
@j0k3r j0k3r added this to the 2.0.0 milestone Mar 7, 2016
j0k3r referenced this issue Mar 7, 2016
@j0k3r
Use external js & css
2766668
@tcitworld
Copy link
Member

Grr, I need to publish the annotator fork on npm, then. :/

@j0k3r
Copy link
Member Author

j0k3r commented Mar 7, 2016

Yup or maybe we can use a custom directive like the repositories in Composer.

@tcitworld tcitworld mentioned this issue Mar 13, 2016
Closed
4 tasks
@nicosomb nicosomb modified the milestones: 2.0.0, 2.1.0 Apr 3, 2016
@tcitworld
Copy link
Member

Now in 2.1 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
3 participants
@j0k3r @nicosomb @tcitworld