V2 use npm #1782
V2 use npm #1782
Conversation
|
Well, I changed a whole lot of things here. The only problem that's left is how to install assets only on one build on Travis. |
| @@ -16,10 +16,10 @@ function retrievePercent(id) { | |||
| if (!supportsLocalStorage()) { return false; } | |||
|
|
|||
| var bheight = $(document).height(); | |||
| var percent = localStorage["poche.article." + id + ".percent"]; | |||
| var percent = localStorage["wallabag.article." + id + ".percent"]; | |||
There was a problem hiding this comment.
I got rid of nostalgia. :)
| "Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::prepareDeploymentTarget", | ||
| "npm install", | ||
| "bower install", | ||
| "grunt" |
There was a problem hiding this comment.
This won't allow us to use a separate build on travis to run asset install.
Don't you started something with a .sh file to handle that ?
There was a problem hiding this comment.
Yeah, but it didn't got me anyway. It launched an extra build for travis instead of using an existing one.
There was a problem hiding this comment.
This could still be a good idea. Look at how I've managed to check for CS & for translated file in one extra build. I prefer one more build instead of all builds taking more than 7 minutes to run ..
There was a problem hiding this comment.
Thing is, we want to install assets by default for the end-user. So the environment parameter should tell my script not to run in some cases.
What it does :
require()app/Ressources/static_global.What doesn't work :