Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistency between favorite / star(red) terms #2041

Closed
bmillemathias opened this issue May 8, 2016 · 2 comments · Fixed by #2221
Closed

consistency between favorite / star(red) terms #2041

bmillemathias opened this issue May 8, 2016 · 2 comments · Fixed by #2221
Assignees
Milestone

Comments

@bmillemathias
Copy link
Contributor

bmillemathias commented May 8, 2016

Issue details

There is some inconsistency in the interface for favorite articles. Sometimes you'll find the term star(red) like on the sidebar but sometimes you'll find the term favorite. On the card of articles the icon to make the article favorite is an heart and not a star :). I know I'm nit-picking

Environment

This is not relevant for this bug but anyway I provide it

  • wallabag version : 2.0.4
  • How did you install wallabag? git clone
  • Last wallabag version that did not exhibit the issue (if applicable): N/a
  • php version: 7.0
  • OS: ubuntu 16.04
  • type of hosting: dedicated
  • which storage system you choose at install: SQLite
@bmillemathias bmillemathias changed the title consistency favorite / starred consistency between favorite / star(red) terms May 8, 2016
@j0k3r
Copy link
Member

j0k3r commented May 8, 2016

Yeah we already fixed some issue like that.

@wallabag/core Should we choose favorite or star ?

@j0k3r j0k3r added the Easy bug label May 8, 2016
@nicosomb
Copy link
Member

nicosomb commented May 9, 2016

starred ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants