Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SERIOUS BUG - Tags clears on all articles after deleting article contains tags #2121

Closed
Rurik19 opened this issue May 27, 2016 · 1 comment · Fixed by #2122
Closed

SERIOUS BUG - Tags clears on all articles after deleting article contains tags #2121

Rurik19 opened this issue May 27, 2016 · 1 comment · Fixed by #2122
Milestone

Comments

@Rurik19
Copy link
Contributor

Rurik19 commented May 27, 2016

Issue details

When I delete article with tags, this tag clears from all other articles! It deleted also from DB, both from w_tag and from w_entry_tag tables
That behaviour is as in site and also in API.
(I'v just lost tag "programming" :-( )

Environment

  • wallabag version 2.0.4

Steps to reproduce/test case

Don't check this with your existing tag...... just with new one.

@j0k3r j0k3r added this to the 2.0.5 milestone May 28, 2016
@j0k3r
Copy link
Member

j0k3r commented May 28, 2016

We are so sorry about that, really.
We'll check that ASAP and submit a fix for the upcoming 2.0.5 (should be released tomorrow)

tcitworld added a commit that referenced this issue Jun 9, 2016
first draft

remote assetic totally

work

nearly there

use at least nodejs > 0.12

use proper version of grunt

bump nodejs version for travis

update npm

workaround for materialize

install node 5.0

add grunt-cli

baggy theme & cache node modules

cache bower & npm

make travis build assets on php7 only

exclude installing node & npm if not needed & use bash

clean & try to make icomoon work on baggy

ready

config for travis

rebase

make travis work

more travis work

impove travis & update deps

add missing pixrem deps

add module through oddly lost

ui updates

install latest nodejs

add install_dev.sh, link local binaries for npm/bower/grunt

ui improvements (mostly baggy)

fix travis build

no need to install on travis

Add unread filter to entries pages

Add the ability to filter for unread pages in the filters menu.

Add unread filter test to EntryControllerTest

Add a new test to the EntryControllerTest collection which checks that
only entries which have not been archived (and are treated as "unread")
are retrieved.

Improve English translation

Update FAQ

-Fix grammar
-Add notes about MTA, firewall, and SELinux

Update installation instructions

-Fix grammar
-Add SELinux section

add screenshots of android docu in English

Fix the deletion of Tags/Entries relation when delete an entry
Fix #2121

Move fixtures to the right place

Display a message when saving an entry failed

When saving an entry fail because of database error we previously just returned `false`.
Now we got an error in the log and the displayed notice to the user is updated too.

Change ManyToMany between entry & tag

Following https://gist.github.com/Ocramius/3121916

Be sure to remove the related entity when removing an entity.

Let say you have Entry -> EntryTag -> Tag.
If you remove the entry:

 - before that commit, the EntryTag will stay (at least using SQLite).
 - with that commit, the related entity is removed

Prepare wallabag 2.0.5

enforce older materialize version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants