Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid EPub export for Kobo devices when title contains '+' #2296

Closed
egilli opened this issue Sep 18, 2016 · 1 comment
Closed

Invalid EPub export for Kobo devices when title contains '+' #2296

egilli opened this issue Sep 18, 2016 · 1 comment
Labels

Comments

@egilli
Copy link
Contributor

egilli commented Sep 18, 2016

Issue details

When exporting an entry with a title containing the + character to epub, the exported file does not work in Kobo devices.
Other characters may trigger the problem, but this is untested (titles with : have some problems with another library).

Environment

  • wallabag version (or git revision) that exhibits the issue: git rev a707643
  • How did you install wallabag? git clone
  • Last wallabag version that did not exhibit the issue (if applicable): N/A
  • php version: PHP 7.0.10
  • OS: Debian testing
  • type of hosting (shared or dedicated): dedicated
  • which storage system you choose at install (SQLite, MySQL/MariaDB or PostgreSQL): SQLite

Steps to reproduce/test case

  1. Add an entry with the character + in its title, like https://en.wikipedia.org/wiki/C++.
  2. Export this entry to the EPub format.
  3. Copy the epub file to a Kobo device (tested with Kobo Glo HD).
  4. Open the file with the Kobo device : the file opens, displaying only the first two pages : cover and table of content.
  5. The content of the entry cannot be read, the device thinks it contains only two pages : the cover and the table of content. The content of the entry is ignored.

(6. Do the same steps, but first edit the entry's title to remove the + : the whole content of the file can now be displayed on the Kobo device.)

I'll do a pull request with a possible correction.

egilli added a commit to egilli/wallabag that referenced this issue Sep 18, 2016
@nicosomb nicosomb added the Bug label Sep 18, 2016
j0k3r added a commit that referenced this issue Sep 19, 2016
Fix issue #2296: epub export with special chars in the title.
@j0k3r j0k3r closed this as completed Sep 19, 2016
@egilli
Copy link
Contributor Author

egilli commented Sep 19, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants