Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config en FR mais langue EN affichée ? #488

Closed
Draky50110 opened this issue Feb 22, 2014 · 24 comments
Closed

Config en FR mais langue EN affichée ? #488

Draky50110 opened this issue Feb 22, 2014 · 24 comments
Assignees
Labels
Milestone

Comments

@Draky50110
Copy link

Salut

J'ai bien mis Wallabag en FR mais les textes dans la partie "config" sont en anglais sauf quelques uns.

wallabag_en-fr

@tcitworld
Copy link
Member

Hi,
(we try to talk english as much as we can)
This problem should have been fixed in #416. Are you using your own file from #487 ? Have you recently upgraded your version ?
I recommend you to clean the cache (delete all files in the cache/ folder) before starting to use wallabag when upgrading.

@Draky50110
Copy link
Author

(t'en foutrais de l'anglais :p )

I'm using Wallabag 1.5.2, cache cleaned after, manually (deleted the cache dir content).
Yes I'm using files from #487 but it occured also with nico's file before.

I juste edited .po files with poedit ;) so no problem from my own file, but inside wallabag...

@tcitworld
Copy link
Member

I confirm bug, whatever theme is.

@tcitworld tcitworld added the Bug label Feb 22, 2014
@mariroz
Copy link
Contributor

mariroz commented Feb 22, 2014

bug is added in last (1.5.2) version and is related to switch language functionality, I think it is related to language names introduction, not to translation files.
It seems, that it's not possible to change language now.

@tcitworld
Copy link
Member

It may be that, but then how come some strings show as translated whereas some aren't ?

@Draky50110
Copy link
Author

Yes, I confirm that some are translated, some not.
For instance : the label on "Login" button is ok in French, also menu items are translated...

@mariroz
Copy link
Contributor

mariroz commented Feb 22, 2014

After clearing cache it is possible to change language. So, it is now possible to repeat this bug. Reason is simple: we don't have translation of all phrases in french language file. I can prepare phrases we need to translate, but don't know french - can't make translation. The same problems are with german (here I can help a bit).

@nicosomb nicosomb added this to the 1.5.3 milestone Feb 22, 2014
@Draky50110
Copy link
Author

Can you add the missing englihh strings in the french .po file ?
Though I'll be able to translate it :)

@mariroz
Copy link
Contributor

mariroz commented Feb 22, 2014

yes, n.p. - will do. Will prepare new .po files for all languages. Hope, on Monday will be ok - it's hard for me to work on weekends.

@tcitworld
Copy link
Member

The hardest work is to find all strings which aren't already in the english .po file (there is quite a lot). Then people will translate it.

@mariroz
Copy link
Contributor

mariroz commented Feb 22, 2014

n.p. - it's not hard. there is standard way how to do that. I think, will describe how to do that, maybe in TRANSLATE.md file: you can use gettext utilites or Poedit, but first it's required to create and run small php script to generate php files from all twig templates. If you will take a look on polish, russian or ukrainian translations - all are more complete as are created 2 weeks ago.

mariroz added a commit to mariroz/wallabag that referenced this issue Feb 24, 2014
@mariroz
Copy link
Contributor

mariroz commented Feb 24, 2014

@Draky50110, pls find new French locale .po file in my commit listed above.
You can edit it with Poedit, for example. Pls let me know, if yo need any help with it.
Other locales: to be continued.

@Draky50110
Copy link
Author

Will look at it as soon as I can ;)

@tcitworld
Copy link
Member

I looked at it and much strings are still with Poche instead of wallabag. Any way you could quickly fix this in the original strings ?

@mariroz
Copy link
Contributor

mariroz commented Feb 24, 2014

yes, I can. will do tomorrow morning.

@tcitworld
Copy link
Member

Well thanks a lot.

@mariroz
Copy link
Contributor

mariroz commented Feb 25, 2014

@tcitworld , all "poche" entries are removed (see my pull request), also updated all .po files - for all languages. English, Polish, Russian and Ukrainian locales are ready to use, other require a lot of translations (more then 100 phrases each).

@Draky50110
Copy link
Author

@mariroz Ok, working on FR .po from your last commit :)

@Draky50110
Copy link
Author

Ok, some things :

  • few strings are duplicate
  • "Poching a link" still "poche" ;)

"poche" dir also still here, for config : inc/poche/ => transform to wallabag dir ?

@Draky50110
Copy link
Author

Done here : http://dl.free.fr/d1xlMbJAO

mariroz added a commit to mariroz/wallabag that referenced this issue Feb 25, 2014
@mariroz
Copy link
Contributor

mariroz commented Feb 25, 2014

Thank you @Draky50110!
yes, "Poching a link" needs to be updated, this is in courgette theme. Will be done soon.

nicosomb added a commit that referenced this issue Feb 25, 2014
French translation added by @Draky50110, issue #488
@tcitworld
Copy link
Member

"poche" dir also still here, for config : inc/poche/ => transform to wallabag dir ?

We keep the name of the /inc/poche directory for practical uses in framabag. This will of course be changed in v2.

@nicosomb
Copy link
Member

Can I close this issue?

@Draky50110
Copy link
Author

Oui :)

@nicosomb nicosomb modified the milestones: 1.6.0, 1.5.3 Mar 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants