Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong display in wallabag (tangledweb.xyz) #5805

Open
wallabag-bot opened this issue May 20, 2022 · 1 comment · May be fixed by j0k3r/php-readability#75
Open

Wrong display in wallabag (tangledweb.xyz) #5805

wallabag-bot opened this issue May 20, 2022 · 1 comment · May be fixed by j0k3r/php-readability#75
Labels
fetch/headings Site Config

Comments

@wallabag-bot
Copy link

Sent by Thomas Citharel and automatically created by email

https://tangledweb.xyz/please-stop-using-grey-text-3d3e71acfca8
@Kdecherf
Copy link
Member

Fetching seems to work pretty well on current master with php-readability 2 improvement.

However some headings are missing, probably through php-readability cleaning

Kdecherf added a commit to Kdecherf/php-readability that referenced this issue Jun 11, 2022
@Kdecherf
Keep h1 and other headings
ada8ff0 
Even though using h1 tags for sections inside an article is semantically
wrong, a lot of websites are doing it anyway. So the idea here is to
stop stripping headings, including h1 on Readability's side.

Fixes wallabag/wallabag#5805

Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
@Kdecherf Kdecherf linked a pull request Jun 11, 2022 that will close this issue
Open
Kdecherf added a commit to Kdecherf/php-readability that referenced this issue Jun 28, 2022
@Kdecherf
Keep h1 and other headings
d3af559 
Even though using h1 tags for sections inside an article is semantically
wrong, a lot of websites are doing it anyway. So the idea here is to
stop stripping headings, including h1 on Readability's side.

Fixes wallabag/wallabag#5805

Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
Kdecherf added a commit to Kdecherf/php-readability that referenced this issue Jun 29, 2022
@Kdecherf
Keep h1 and other headings
41ef592 
Even though using h1 tags for sections inside an article is semantically
wrong, a lot of websites are doing it anyway. So the idea here is to
stop stripping headings, including h1 on Readability's side.

Fixes wallabag/wallabag#5805

Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
@Strubbl Strubbl changed the title Wrong display in wallabag Wrong display in wallabag (tangledweb.xyz) Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fetch/headings Site Config
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Keep h1 and other headings Kdecherf/php-readability
2 participants
@Kdecherf @wallabag-bot