Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The link to check the server compatibility is broken #858

Closed
Guish59 opened this issue Oct 6, 2014 · 12 comments
Closed

The link to check the server compatibility is broken #858

Guish59 opened this issue Oct 6, 2014 · 12 comments
Labels
Milestone

Comments

@Guish59
Copy link

Guish59 commented Oct 6, 2014

On master, when you click on the link to check your server compatibility on the index page of install, it's a 404 error page.

@tcitworld
Copy link
Member

Strange. Do you get it with accessing to /mywallabagURL/wallabag_compatibility_test.php ?

@Guish59
Copy link
Author

Guish59 commented Oct 6, 2014

Yes i can access with your URL but the link on install/index.php it's wrong.
The '/' is missing in the href on the line 229.

@tcitworld
Copy link
Member

Strange, I do manage to get it. Could it be a specific server configuration ?
If we add the '/', it will redirect to the root of the host (for instance from localhost/wallabag/index.php to localhost/wallabag_compatibility_test.php) and therefore will not be found.

@tcitworld
Copy link
Member

Where does the link currently sends you by the way ?

@Guish59
Copy link
Author

Guish59 commented Oct 6, 2014

in the install/index.php page.
My DocumentRoot is the root directory of the project.
Another solutions are to put "../" or to move the wallabag_compatibility_test.php in the install directory.

@tcitworld
Copy link
Member

I think the main problem comes from the fact the root of the project brings up the install.php page without redirecting.

@nicosomb
Copy link
Member

nicosomb commented Oct 8, 2014

You're right, Thomas. If wallabag is not yet installed, we are redirected to install/index.php, so we can't access to wallabag_compatibility_test.php.

I'll move it into install folder.

@nicosomb nicosomb added the Bug label Oct 8, 2014
@nicosomb nicosomb modified the milestone: 1.8.0 Oct 8, 2014
tcitworld added a commit that referenced this issue Oct 8, 2014
@tcitworld
Copy link
Member

Done.

@nicosomb
Copy link
Member

nicosomb commented Oct 8, 2014

And 1.8.0 is now over \o/

@tcitworld
Copy link
Member

:)

@tcitworld
Copy link
Member

we can't access to wallabag_compatibility_test.php. I'll move it into install folder.

One of the drawbacks of doing this is that users can't look up this page to see if their server misses something after or before installating.
My branch newinstall integrates the checking on the same page the install does take places, but I guess it would be good also to keep having this page someplace.
A pretty good idea would be to have an About page (or a subsection of Config screen) which displays Version information, licence, about software, changelog and also these checks.

@nicosomb
Copy link
Member

New issue ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants