V2 api authentication #1068
V2 api authentication #1068
Conversation
|
@j0k3r You can already have a look to this PR. I still have stuff to do. |
| @@ -21,6 +21,8 @@ | |||
| class="Wallabag\CoreBundle\Security\Firewall\WsseListener" public="false"> | |||
There was a problem hiding this comment.
We need to choose which format we are going to use for declaring services, instead of mixing xml & yml. I'm more familiar with yml :)
There was a problem hiding this comment.
I also prefer yml. But I heard that "symfony standards" for services is XML.
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh wait, I'll send a mail to my sensio colleagues and my symfony teacher!
There was a problem hiding this comment.
If you want, you can convert this file into yml one. I add a task in trello.
|
I replaced services.xml file. Can you confirm it's good for you? |
|
Seems to be good 👍 |
|
Ready for review. |
|
Fixed your review. |
|
It would great if you had some simple test to validate that getting entries, authenticate usingthe api works, etc .. |
|
There is an other PR for tests: #1070 If this one seems good for you, let's merge! |
Authentication for API, based on WSSE http://obtao.com/blog/2013/06/configure-wsse-on-symfony-with-fosrestbundle/
About salt: http://stackoverflow.com/questions/213380/the-necessity-of-hiding-the-salt-for-a-hash
For generating correct headers: http://www.teria.com/~koseki/tools/wssegen/
For testing API, install Rest console plugin for Chrome or Firefox.