-
-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 config #1095
Conversation
$config = new Config(); | ||
$config->setUser($user); | ||
$config->setTheme('baggy'); | ||
$config->setItemsPerPage(10); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
12 is the new default value ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't there be a config file for default values ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's the purpose of parameters.yml.dist
. I didn't use it atm, but we'll have to in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I'm sorry, didn't saw the file.
I wonder if theme / language / etc have to be stored in config table or user table. |
Hmm, tricky question. If we put them in the user table, I guess we will quickly have too much columns. |
I asked myself the same question. I ended up using a different table to separate such information and avoid to much noise in the user table. But we can change it |
That's why I asked you ;-) |
Also add fixtures for Config InstallCommand now check if database, schema are here and ask the user what to do (keep or trash & re-create)
@nicosomb if everything seems ok to you, it's ready to merge 👍 |
I switched on your branch, removed my database, executed
and when I tried to connect myself, |
I've added some new parameters in |
It works 👍 |
All seems good for me. Still in WIP or not? |
No more :) |
The config page:
I also improved InstallCommand & add tests
Will fix #800
Related #673