V2 theme #1132
Merged
V2 theme #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| load_controllers: false | ||
| themes: | ||
| - baggy | ||
| - courgette |
There was a problem hiding this comment.
you can really remove courgette one :)
Re-defined the config / user relation to be OneToOne bidirectionnal. ConfigType is now a service so I can inject the list of available themes that are also used by LiipThemeBundle Force sqlite for test In case of people use a different driver in parameter.yml (yes I do :))
|
I've updated the description with what I did. |
Others patterns aren't required (but I think it's still important to have them around)
|
Great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, to sum up what I did:
app/Resources/views/andsrc/Wallabag/CoreBundle/Resources/views/themes/)wallabag_core.helper.detect_active_themewhich help the bundle to define which theme is active by looking a the Config entry.layout.html.twigin a new theme folder and but your own js / css, see the baggy one)I will later write a quick help on to write your own theme. Maybe when we'll have chosen the official v2 theme :)