Adds pagerfanta paginator everywhere, modifies article routing. #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,77 +13,66 @@ class EntryRepository extends EntityRepository | |||
| * Retrieves unread entries for a user. | |||
| * | |||
| * @param int $userId | |||
| * @param int $firstResult | |||
| * @param int $maxResults | |||
| * | |||
| * @return Paginator | |||
There was a problem hiding this comment.
Could you adjust the docblock for every function? It now returns a DoctrineORMAdapter.
Also, you can remove the use Doctrine\ORM\Tools\Pagination\Paginator;
|
Sadly test are failing but it seems to be unrelated to your change. |
|
@j0k3r Ok, I'll check tests today. |
…e API for is_starred and is_archived
|
It was related to my changes. I modified routing :
Let me know if you want me to change routing. |
|
Great thanks @frankoa 👍 |
j0k3r
added a commit
that referenced
this pull request
Jul 29, 2015
Adds pagerfanta paginator everywhere, modifies article routing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds pagerfanta paginator everywhere, and modifies article routing.
Change API for is_starred and is_archived. (Reflects the output of the API 'getEntries')