fix security bug with PHP_AUTH_USER #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just sent an email to Milan Holzäpfel, I asked him to make a review of your PR (and I forgot you in cc ..). |
|
Well, the PR is just his patch. I didn't got the time to test it in all kinds of configurations though, so I open it to everyone. |
|
It fixes the bug, that's for sure. We just need to be sure if it works on particular installations. |
|
But what's the bug? Any description somewhere? |
|
Well, I'm ok with that 👍 |
|
I'm sending you the details by email. |
|
@tcitworld Nico already send them to me, thanks :) |
|
Okay, then I will merge before next version (which I would like to be out tomorrow, I'm away starting from Friday) |
|
Do you want / can you write a blog post about 1.9.2? |
|
Yup, I will write it tomorrow. |
tcitworld
added a commit
that referenced
this pull request
Jul 30, 2015
fix security bug with PHP_AUTH_USER
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to M. Holzäpfel.