Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags list display #1292

Merged
merged 3 commits into from
Aug 9, 2015
Merged

Add tags list display #1292

merged 3 commits into from
Aug 9, 2015

Conversation

nicosomb
Copy link
Member

@nicosomb nicosomb commented Aug 7, 2015

No description provided.

@nicosomb nicosomb added this to the 2.0 milestone Aug 7, 2015
@nicosomb nicosomb changed the title Add tags list display [WIP] Add tags list display Aug 7, 2015
@nicosomb nicosomb changed the title [WIP] Add tags list display Add tags list display Aug 7, 2015
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\Request;
use Wallabag\CoreBundle\Entity\Tag;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you don't need these two lines

@j0k3r
Copy link
Member

j0k3r commented Aug 7, 2015

Don't forget tests 😉

@nicosomb
Copy link
Member Author

nicosomb commented Aug 7, 2015

Sorry, I fixed my PR.

j0k3r added a commit that referenced this pull request Aug 9, 2015
@j0k3r j0k3r merged commit 47cadf3 into v2 Aug 9, 2015
@j0k3r j0k3r deleted the v2-tags-route branch August 9, 2015 20:47
@nicosomb nicosomb modified the milestones: 2.0, 2.0.0-alpha Aug 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants