Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add howto page #1295

Merged
merged 3 commits into from
Aug 10, 2015
Merged

add howto page #1295

merged 3 commits into from
Aug 10, 2015

Conversation

nicosomb
Copy link
Member

@nicosomb nicosomb commented Aug 7, 2015

No description provided.

@nicosomb nicosomb added this to the 2.0 milestone Aug 7, 2015
@j0k3r
Copy link
Member

j0k3r commented Aug 9, 2015

Could you add a simple test that get the page and check the returned status ?

@nicosomb
Copy link
Member Author

Done.

namespace Wallabag\CoreBundle\Tests\Controller;

use Wallabag\CoreBundle\Tests\WallabagCoreTestCase;
use Doctrine\ORM\AbstractQuery;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need this line

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grrr, sorry for that. Fixed.

j0k3r added a commit that referenced this pull request Aug 10, 2015
@j0k3r j0k3r merged commit f48a018 into v2 Aug 10, 2015
@j0k3r j0k3r deleted the v2-howto branch August 10, 2015 12:15
@nicosomb nicosomb modified the milestones: 2.0, 2.0.0-alpha Aug 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants