-
-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix material #1298
fix material #1298
Conversation
…les on 1st line, 3 on 2nd one, only 1 on 3rd line and 3 on last lines (chrome and firefox))
All notification corrected
yeah, good job guy. I like the notifications 👍 |
<i class="mdi-navigation-close"></i> | ||
</div> | ||
</form> | ||
<!--<form name="entry" method="post" action="{{ path('new_entry') }}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"add a new link" form will be displayed in the header? Or is that dead code?
just 2 comments, we can merge after that. |
When you are able to add articles I uncomment. If I understand correctly, it is now possible to add articles from the page ONLY http://site.com/new, because you want to pass the token |
yes, you can add new articles from this page only. So you can implement form in the header I think. |
Please tell me how to do it |
OK, I'll do that after my current work. |
Also, could you rebase your branch against the v2 to fix conflicts? |
# Conflicts: # src/Wallabag/CoreBundle/Resources/views/themes/material/base.html.twig
Up |
# Conflicts: # src/Wallabag/CoreBundle/Resources/views/themes/material/base.html.twig
I merged your PR. About new link form, my PR #1307 is not yet finished, so I think it's better for you to work on a new PR. |
No description provided.