add new post form in material header #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -58,7 +58,7 @@ | |||
| </div> | |||
| <div class="input-field nav-panel-buttom"> | |||
| <ul> | |||
| <li class="bold"><a class="waves-effect" href="{{ path('new_entry') }}" id="nav-btn-add"><i class="mdi-content-add"></i></a></li> | |||
| <li class="bold"><a class="waves-effect" href="javascript: void(null);" id="nav-btn-add"><i class="mdi-content-add"></i></a></li> | |||
There was a problem hiding this comment.
I think you can let the url inside the href {{ path('new') }}. In that case, if every thing goes well, user will have js fully load and will have the js form poped. In any other case, bad network connection, js error, etc ... it will still be able to add an entry because it will be redirected to the new form page.
There was a problem hiding this comment.
I will try it and will change it if it's good.
nicosomb
force-pushed
the
v2-form-header
branch
from
acf17d4
to
053b956
Compare
|
@j0k3r I changed the href (your method works well 👍 ) |
|
You don't need to push force every time you udpate a PR :) |
j0k3r
added a commit
that referenced
this pull request
Aug 12, 2015
add new post form in material header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces #1307 (I had problems with merge, some files were deleted, I made so many mistakes I think)