Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable download links on entry view #1331

Merged
merged 1 commit into from
Aug 12, 2015
Merged

disable download links on entry view #1331

merged 1 commit into from
Aug 12, 2015

Conversation

nicosomb
Copy link
Member

only because export is still not yet implemented.

@nicosomb nicosomb added this to the 2.0.0-alpha.0 milestone Aug 12, 2015
@tcitworld
Copy link
Member

<strike> is depreciated with html5. Can you use <del> instead ?

@nicosomb
Copy link
Member Author

Sure I can.

@nicosomb
Copy link
Member Author

done

<span>{% trans %}Download{% endtrans %}</span>
</a>
<span><del>{% trans %}Download{% endtrans %}</del></span>
</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra useless tabulation? :)

@nicosomb
Copy link
Member Author

Fixed.

@j0k3r
Copy link
Member

j0k3r commented Aug 12, 2015

Aaaaand now you can squash everything so we can merge it!

@nicosomb
Copy link
Member Author

squash

@j0k3r
Copy link
Member

j0k3r commented Aug 12, 2015

👍 😆

j0k3r added a commit that referenced this pull request Aug 12, 2015
disable download links on entry view
@j0k3r j0k3r merged commit 545b852 into v2 Aug 12, 2015
@j0k3r j0k3r deleted the v2-disable-download branch August 12, 2015 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants