Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes material #1337

Merged
merged 12 commits into from
Aug 17, 2015
Merged

fixes material #1337

merged 12 commits into from
Aug 17, 2015

Conversation

modos189
Copy link
Contributor

No description provided.

@modos189
Copy link
Contributor Author

I replaced the {{form_rest (form)}} manual entry of each field, so the system does not assign values to them. As it can improve?

@j0k3r
Copy link
Member

j0k3r commented Aug 12, 2015

You shouldn't do that.
Check the documentation http://symfony.com/fr/doc/current/reference/forms/twig_reference.html

@modos189
Copy link
Contributor Author

Up

@tcitworld
Copy link
Member

Saying « up » doesn't make things go faster.

@modos189
Copy link
Contributor Author

Hmm. I am not receiving notification of new commits in other pull-request by mail, only the comments, so I wrote it.
Ok, I will not)

@nicosomb
Copy link
Member

that's a lack on github, you're right...

@nicosomb
Copy link
Member

Good job 👍

  • When I click on "new article" icon, and on the cross after, the filter icon is no more visible.
  • When I change the size of my browser window, the filter appears but I didn't click on the icon
  • Add a cross at the top right of the filter bar
  • Bug: can't click on pagination > 1
  • display bug: when we load homepage, we see quickly the filter form
  • new entry form: when we click on the field, the history of the field is at the left of the screen, not below the field (see screenshot)

Alexandr Danilov added 5 commits August 17, 2015 00:33
    When I click on "new article" icon, and on the cross after, the filter icon is no more visible.
    When I change the size of my browser window, the filter appears but I didn't click on the icon
    Bug: can't click on pagination > 1
    display bug: when we load homepage, we see quickly the filter form
    new entry form: when we click on the field, the history of the field is at the left of the screen, not below the field (see screenshot)
@nicosomb
Copy link
Member

Yeah, calendars :-)

little bugs:

  • on mobile view, if I click on sandwich icon, I can't close the sidebar.
  • on chromium, I can't display calendars.
  • on firefox, I can display calendar. But I can't see buttons to close the calendar.
  • Is that possible to reduce the calendar size?

@modos189
Copy link
Contributor Author

on mobile view, if I click on sandwich icon, I can't close the sidebar.

As it turned out, the framework materializecss not support simultaneous operation of two sidenav. I fixed a bug in the framework and send a separate PR

<label for="entry_filter_createdAt_left_date" class="active">{% trans %}from{% endtrans %}</label>
</div>
<div class="input-field col s6">
{{ form_widget(form.createdAt.right_date, {'type': 'date', 'attr': {'class': 'datepicker', 'data-value': form.createdAt.left_date.vars.value} }) }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

form.createdAt.left_date.vars.value => form.createdAt.right_date.vars.value

nicosomb added a commit that referenced this pull request Aug 17, 2015
@nicosomb nicosomb merged commit 925d8ab into wallabag:v2 Aug 17, 2015
@nicosomb
Copy link
Member

\o/

@modos189
Copy link
Contributor Author

=)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants