Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #1350: fix pagination with filters #1352

Merged
merged 2 commits into from
Aug 17, 2015
Merged

fix #1350: fix pagination with filters #1352

merged 2 commits into from
Aug 17, 2015

Conversation

nicosomb
Copy link
Member

@j0k3r : tests needed?

@nicosomb nicosomb added this to the 2.0.0-alpha.0 milestone Aug 17, 2015
@j0k3r
Copy link
Member

j0k3r commented Aug 17, 2015

You can add a little one:

  • navigate to a page with parameters
  • check that the pagination link still contains parameters

@nicosomb
Copy link
Member Author

Done (you want my death :P)

@j0k3r
Copy link
Member

j0k3r commented Aug 17, 2015

👍

j0k3r added a commit that referenced this pull request Aug 17, 2015
@j0k3r
Merge pull request #1352 from wallabag/v2-fix-pagination
0a3a5f6 
fix #1350: fix pagination with filters
@j0k3r j0k3r merged commit 0a3a5f6 into v2 Aug 17, 2015
@j0k3r j0k3r deleted the v2-fix-pagination branch August 17, 2015 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@j0k3r j0k3r

Labels
None yet
Projects
None yet
Milestone
2.0.0-alpha.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicosomb @j0k3r