Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter for entries with previewPicture #1418

Merged
merged 3 commits into from
Sep 13, 2015
Merged

filter for entries with previewPicture #1418

merged 3 commits into from
Sep 13, 2015

Conversation

nicosomb
Copy link
Member

No description provided.

@nicosomb nicosomb added this to the 2.0.0-alpha.0 milestone Sep 12, 2015
@tcitworld
Copy link
Member

I didn't find this filter much useful, at first, but then I thought you could remember the picture instead of the title.

@nicosomb nicosomb changed the title [WIP] filter for entries with previewPicture filter for entries with previewPicture Sep 13, 2015
->add('isStarred', 'filter_checkbox')
->add('previewPicture', 'filter_checkbox', array(
'apply_filter' => function (QueryInterface $filterQuery, $field, $values) {
$value = $values['value'];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you won't use $value after, you can directly use $values['value'] in your if case.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed (and already squashed)

j0k3r added a commit that referenced this pull request Sep 13, 2015
filter for entries with previewPicture
@j0k3r j0k3r merged commit 40f59b2 into v2 Sep 13, 2015
@j0k3r j0k3r deleted the v2-previewpicture-filter branch September 13, 2015 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants