Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved display pictures #1420

Merged
merged 1 commit into from
Sep 14, 2015
Merged

Conversation

modos189
Copy link
Contributor

No description provided.

@j0k3r
Copy link
Member

j0k3r commented Sep 14, 2015

Screenshot?

height: 22em;
overflow: hidden;
}

img.preview {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you remove these lines, preview picture display is broken on article view (picture is too huge)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To limit the size I use lines 265 to 275

@nicosomb
Copy link
Member

Before

After

@modos189
Copy link
Contributor Author

Regard to the screenshot, I think, when you click on the picture better show the title and description, without the website address

@nicosomb
Copy link
Member

No problem for that.
Did you see my comment about article view?

nicosomb added a commit that referenced this pull request Sep 14, 2015
@nicosomb nicosomb merged commit 1db9d41 into wallabag:v2 Sep 14, 2015
@modos189
Copy link
Contributor Author

About "img.preview"? Yes, i answered)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants