Public registration & oAuth2 \o/ #1436

nicosomb · 2015-09-29T12:33:04Z

public registration
remove WSSE implementation
add oAuth2 implementation

nicosomb · 2015-09-29T12:36:53Z

Sorry, I created a big PR.

nicosomb · 2015-09-29T12:43:46Z

Todo:

a nice form for registration
we can't access to /api/doc and I don't know why
tests

j0k3r · 2015-09-29T13:34:44Z

Wow, good job.

nicosomb · 2015-09-29T13:36:23Z

I need to talk with you about passwords.

j0k3r · 2015-09-29T14:23:38Z

src/Wallabag/CoreBundle/EventListener/AuthenticationListener.php

+            return;
+        }
+
+        $config = new Config($event->getUser());


Could you put a comment on that class to explain that it is called after a user is registered?
Or maybe renamed it to RegistratioConfirmedListener to be more explicit.

nicosomb · 2015-09-29T15:06:07Z

I added tests for public registration. Do you think it's enough for this feature? And for this PR?

For example, I didn't write tests for email validation.

j0k3r · 2015-09-29T15:12:49Z

You can add unit test for RegistrationConfirmedListener.
And you can run phpunit --coverage-html build/coverage, wait 30 minutes (...) and see where you still need some tests.

Well, validation email are already tested in FosUser I guess.

nicosomb · 2015-09-29T18:17:03Z

Added a test on RegistrationConfirmedListener.

j0k3r · 2015-09-30T07:04:30Z

Thanks for the functional test but I was talking about a unit test (which doesn't load all Symfony) but only the RegistrationConfirmedListener class. Like in UsernameRssTokenConverterTest.

nicosomb · 2015-10-02T04:21:31Z

oops, sorry for the container :-(

nicosomb · 2015-10-02T04:22:00Z

and thank you for the test 👍 !
This PR is ready for review !

j0k3r · 2015-10-02T07:42:32Z

Next step: remove what we've done about forgot password, login, etc .. to use FOS

nicosomb · 2015-10-02T07:43:05Z

Planned. And also create a UserBundle.

nicosomb · 2015-10-03T04:40:15Z

Ooooh I don't know what I did :( all these commits ...

* remove WSSE implementation * add oAuth2 implementation

* add tests

@nicosomb

And PLEASE @nicosomb, NEVER EVER inject the whole container inside a service.

j0k3r · 2015-10-03T11:33:21Z

I think I've fixed the mess :)
I guess you killed your repo by rebasing the branch against the v2, maybe in a wrong way.

I've cherry-picked your 2 commits and fixed few things.
Also, now with the UserBundle, testing with coverage is like ... taking ages ... 😕

PHPUnit 4.8.10 by Sebastian Bergmann and contributors.

................................................................. 65 / 86 ( 75%)
.....................

Time: 25.59 minutes, Memory: 287.50Mb

OK (86 tests, 337 assertions)

Generating code coverage report in HTML format ... done

- remove unecessary routing for UserBundle - remove unused form type

nicosomb · 2015-10-04T19:04:05Z

thank you for your help!

j0k3r · 2015-10-05T05:48:43Z

There are still some work to be done :)

baggy registration page
a better forgot password page
a functional test on registration (because we use a, even small, custom form type)

nicosomb · 2015-10-05T07:14:15Z

graby registration page

What is it?

I will work on the other tasks soon.

j0k3r · 2015-10-05T07:15:11Z

Woops, I said graby but I wanted to say baggy 😄

tcitworld · 2015-10-05T19:57:25Z

Why is the name field a textarea ? Be sure to make it optional.

nicosomb · 2015-10-05T19:58:00Z

It's already deleted in next commits ;-)

nicosomb · 2015-10-05T20:21:04Z

a functional test on registration (because we use a, even small, custom form type)

I removed RegistrationType.php. Is the test still necessary?

I have to work on baggy form, but material is now OK :-)

j0k3r · 2015-10-05T20:31:11Z

I tried to remove RegistrationType but got an error in the test suite ..
Oh maybe because I didn't update config.yml :)

nicosomb · 2015-10-05T20:31:58Z

RegistrationType was removed in my last commit and test suite seems to be green.

nicosomb · 2015-10-05T20:50:48Z

Ready for last review.

j0k3r · 2015-10-06T07:18:40Z

Should be ok for now, we'll see later if we need improvment.
Good job 👍

Public registration & oAuth2 \o/

nicosomb added this to the 2.0.0-alpha.1 milestone Sep 29, 2015

j0k3r added the Work in progress label Sep 29, 2015

nicosomb force-pushed the v2-register branch from 69b054c to 024a536 Compare September 29, 2015 12:35

j0k3r reviewed Sep 29, 2015
View reviewed changes

nicosomb changed the title ~~[WIP] Public registration & oAuth2 \o/~~ Public registration & oAuth2 \o/ Sep 29, 2015

nicosomb added Ready for review and removed Work in progress labels Sep 29, 2015

nicosomb assigned j0k3r Sep 29, 2015

nicosomb mentioned this pull request Sep 29, 2015

oAuth implementation #795

Closed

j0k3r force-pushed the v2-register branch from 01ba207 to 1cf538b Compare October 3, 2015 11:30

nicosomb and others added 7 commits October 3, 2015 13:30

* public registration

fcb1fba

* remove WSSE implementation * add oAuth2 implementation

allow API documentation for anonymous

cd1298d

check authentication on each API route

7727325

* rename AuthenticationListener

359b3f4

* add tests

add test for confirmed registration

2c13918

Add test on RegistrationConfirmedListener

772d8c4

And PLEASE @nicosomb, NEVER EVER inject the whole container inside a service.

remove old implementation for login/register/recover

1210dae

move some files to UserBundle

0a87846

j0k3r force-pushed the v2-register branch from 1cf538b to fd5f406 Compare October 3, 2015 11:31

Cleanup

4c5e544

- remove unecessary routing for UserBundle - remove unused form type

j0k3r force-pushed the v2-register branch from fd5f406 to 4c5e544 Compare October 3, 2015 11:37

j0k3r added Work in progress and removed Ready for review labels Oct 3, 2015

material design for register/login/recover pages

ec3ce59

Nicolas Lœuillet added 2 commits October 5, 2015 22:45

last changes for baggy theme

d302621

move css

e0d1888

nicosomb added Ready for review and removed Work in progress labels Oct 5, 2015

use form widget for registration

8263e71

j0k3r added a commit that referenced this pull request Oct 6, 2015

Merge pull request #1436 from wallabag/v2-register

16dabc3

Public registration & oAuth2 \o/

j0k3r merged commit 16dabc3 into v2 Oct 6, 2015

j0k3r deleted the v2-register branch October 6, 2015 07:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Public registration & oAuth2 \o/ #1436

Public registration & oAuth2 \o/ #1436

nicosomb commented Sep 29, 2015

nicosomb commented Sep 29, 2015

nicosomb commented Sep 29, 2015

j0k3r commented Sep 29, 2015

nicosomb commented Sep 29, 2015

j0k3r Sep 29, 2015

nicosomb Sep 29, 2015

nicosomb commented Sep 29, 2015

j0k3r commented Sep 29, 2015

nicosomb commented Sep 29, 2015

j0k3r commented Sep 30, 2015

nicosomb commented Oct 2, 2015

nicosomb commented Oct 2, 2015

j0k3r commented Oct 2, 2015

nicosomb commented Oct 2, 2015

nicosomb commented Oct 3, 2015

j0k3r commented Oct 3, 2015

nicosomb commented Oct 4, 2015

j0k3r commented Oct 5, 2015

nicosomb commented Oct 5, 2015

j0k3r commented Oct 5, 2015

tcitworld commented Oct 5, 2015

nicosomb commented Oct 5, 2015

nicosomb commented Oct 5, 2015

j0k3r commented Oct 5, 2015

nicosomb commented Oct 5, 2015

nicosomb commented Oct 5, 2015

j0k3r commented Oct 6, 2015

Public registration & oAuth2 \o/ #1436

Public registration & oAuth2 \o/ #1436

Conversation

nicosomb commented Sep 29, 2015

nicosomb commented Sep 29, 2015

nicosomb commented Sep 29, 2015

j0k3r commented Sep 29, 2015

nicosomb commented Sep 29, 2015

j0k3r Sep 29, 2015

Choose a reason for hiding this comment

nicosomb Sep 29, 2015

Choose a reason for hiding this comment

nicosomb commented Sep 29, 2015

j0k3r commented Sep 29, 2015

nicosomb commented Sep 29, 2015

j0k3r commented Sep 30, 2015

nicosomb commented Oct 2, 2015

nicosomb commented Oct 2, 2015

j0k3r commented Oct 2, 2015

nicosomb commented Oct 2, 2015

nicosomb commented Oct 3, 2015

j0k3r commented Oct 3, 2015

nicosomb commented Oct 4, 2015

j0k3r commented Oct 5, 2015

nicosomb commented Oct 5, 2015

j0k3r commented Oct 5, 2015

tcitworld commented Oct 5, 2015

nicosomb commented Oct 5, 2015

nicosomb commented Oct 5, 2015

j0k3r commented Oct 5, 2015

nicosomb commented Oct 5, 2015

nicosomb commented Oct 5, 2015

j0k3r commented Oct 6, 2015