[WIP] language selection on config screen #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,7 +41,7 @@ public function indexAction(Request $request) | |||
|
|
|||
| $this->get('session')->getFlashBag()->add( | |||
| 'notice', | |||
| 'Config saved' | |||
| 'Config saved. Some parameters will be considered after disconnection.' | |||
There was a problem hiding this comment.
Don't forget to update the translation after that.
|
any idea on how can I write a test for this feature? |
|
I will have a look. |
nicosomb
changed the title
j0k3r
force-pushed
the
v2-language-config
branch
from
8d0372b
to
c89d35e
Compare
|
Thank you @j0k3r for the test. If it's good for you, we can merge. |
nicosomb
added a commit
that referenced
this pull request
Oct 18, 2015
[WIP] language selection on config screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need one test on listener. I wait for @j0k3r and the other PR.