Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2factor authentication via email #1484

Merged
merged 4 commits into from
Oct 15, 2015
Merged

2factor authentication via email #1484

merged 4 commits into from
Oct 15, 2015

Conversation

nicosomb
Copy link
Member

2factor authentication via email.
This setting can be disabled on config screen for each user.
User can also check "trusted computer" to avoid 2factor authentication for a delay.

Here is a screenshot after login step.

It's also possible to enable Google Authenticator, but I don't know if we need this validator. @j0k3r @tcitworld any opinion?

trusted_computer:
enabled: true
cookie_name: wllbg_trusted_computer
cookie_lifetime: 5184000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe 30 days without access is enough ? 60 seems big to me.

@j0k3r
Copy link
Member

j0k3r commented Oct 13, 2015

Where are tests related to that part?

@nicosomb
Copy link
Member Author

I don't know if tests are needed: the bundle is tested and I don't override the bundle behaviour.

@j0k3r
Copy link
Member

j0k3r commented Oct 13, 2015

I don't agree.

For example, you added form.user.twoFactorAuthentication in the configuration panel. What if user doesn't enable it, you should test that he won't get the form to put the 2 factor code. On the other side, if user enable it, you should test that the form will be shown when user log in.

Also, you added some logic in the User entity that need to be tested: isTrustedComputer.

@nicosomb
Copy link
Member Author

OK, I will add tests.

@nicosomb
Copy link
Member Author

Tests added.


scheb_two_factor:
trusted_computer:
enabled: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about these config to enable two factor.
I think they should be in parameters.yml so people won't have to update config.yml and keep a modified file which can be problematic when updating wallabag.

Also, the sender_email should be in parameters.yml

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

j0k3r added a commit that referenced this pull request Oct 15, 2015
2factor authentication via email
@j0k3r j0k3r merged commit 3d3ed95 into v2 Oct 15, 2015
@j0k3r j0k3r deleted the v2-2factor-auth branch October 15, 2015 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants