Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Symfony 3.0 #1524

Merged
merged 20 commits into from
Jan 15, 2016
Merged

Upgrade to Symfony 3.0 #1524

merged 20 commits into from
Jan 15, 2016

Conversation

j0k3r
Copy link
Member

@j0k3r j0k3r commented Dec 6, 2015

@j0k3r j0k3r added this to the 2.0.0-alpha.1 milestone Dec 6, 2015
@nicosomb
Copy link
Member

Do you plan to fix these bundles? Or do you think we have to wait for updates?

@j0k3r
Copy link
Member Author

j0k3r commented Dec 22, 2015

I've started to fix the first one.
Other bundles have PRs for that, we just need to wait for them to be reviewed, merged and released.

@j0k3r j0k3r modified the milestones: 2.0.0, 2.0.0-alpha.1 Dec 22, 2015
@j0k3r j0k3r force-pushed the sf2.8 branch 2 times, most recently from 59f705f to 1897f14 Compare December 24, 2015 07:57
@j0k3r j0k3r force-pushed the sf2.8 branch 2 times, most recently from f3dcc98 to ce70387 Compare January 9, 2016 13:58
@j0k3r j0k3r changed the title WIP – Upgrade to Symfony 2.8 WIP – Upgrade to Symfony 3.0 Jan 14, 2016
@nicosomb
Copy link
Member

Yeah! Still in WIP?

@j0k3r j0k3r changed the title WIP – Upgrade to Symfony 3.0 Upgrade to Symfony 3.0 Jan 15, 2016
@j0k3r j0k3r modified the milestones: 2.0.0-beta.1, 2.0.0 Jan 15, 2016
nicosomb
nicosomb reviewed Jan 15, 2016
View reviewed changes
.gitignore
/var/bootstrap.php.cache
/bin/*
!bin/console
!bin/symfony_requirements
/vendor/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines are missing:

# Docker container logs and data
docker/logs/
docker/data/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is because my branch is outdated regarding the master.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v2, not master ;-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You get it 😁
Rebased ✅

@nicosomb
Copy link
Member

In README.md, you have to change with that:

php bin/console wallabag:install
php bin/console server:run

@j0k3r
Update deps
e23edfd 
Changelogs summary:

 - doctrine/cache updated from v1.5.1 to v1.5.2
   See changes: doctrine/cache@v1.5.1...v1.5.2
   Release notes: https://github.com/doctrine/cache/releases/tag/v1.5.2

 - doctrine/common updated from v2.5.1 to v2.5.2
   See changes: doctrine/common@v2.5.1...v2.5.2
   Release notes: https://github.com/doctrine/common/releases/tag/v2.5.2

 - symfony/polyfill-mbstring installed in version v1.0.0
   Release notes: https://github.com/symfony/polyfill-mbstring/releases/tag/v1.0.0

 - symfony/polyfill-util installed in version v1.0.0
   Release notes: https://github.com/symfony/polyfill-util/releases/tag/v1.0.0

 - paragonie/random_compat installed in version 1.1.1
   Release notes: https://github.com/paragonie/random_compat/releases/tag/1.1.1

 - symfony/polyfill-php70 installed in version v1.0.0
   Release notes: https://github.com/symfony/polyfill-php70/releases/tag/v1.0.0

 - symfony/polyfill-php56 installed in version v1.0.0
   Release notes: https://github.com/symfony/polyfill-php56/releases/tag/v1.0.0

 - ircmaxell/password-compat installed in version v1.0.4
   Release notes: https://github.com/ircmaxell/password_compat/releases/tag/v1.0.4

 - symfony/polyfill-php55 installed in version v1.0.0
   Release notes: https://github.com/symfony/polyfill-php55/releases/tag/v1.0.0

 - symfony/polyfill-php54 installed in version v1.0.0
   Release notes: https://github.com/symfony/polyfill-php54/releases/tag/v1.0.0

 - symfony/polyfill-intl-icu installed in version v1.0.0
   Release notes: https://github.com/symfony/polyfill-intl-icu/releases/tag/v1.0.0

 - symfony/symfony updated from v2.7.7 to v2.8.0
   See changes: symfony/symfony@v2.7.7...v2.8.0
   Release notes: https://github.com/symfony/symfony/releases/tag/v2.8.0

 - symfony/security-acl installed in version v2.7.7
   Release notes: https://github.com/symfony/security-acl/releases/tag/v2.7.7

 - doctrine/orm updated from v2.5.1 to v2.5.2
   See changes: doctrine/orm@v2.5.1...v2.5.2
   Release notes: https://github.com/doctrine/doctrine2/releases/tag/v2.5.2

 - kriswallsmith/assetic updated from v1.3.1 to v1.3.2
   See changes: kriswallsmith/assetic@v1.3.1...v1.3.2
   Release notes: https://github.com/kriswallsmith/assetic/releases/tag/v1.3.2

 - symfony/assetic-bundle updated from v2.7.0 to v2.7.1
   See changes: symfony/assetic-bundle@v2.7.0...v2.7.1
   Release notes: https://github.com/symfony/assetic-bundle/releases/tag/v2.7.1

 - symfony/swiftmailer-bundle updated from v2.3.8 to v2.3.9
   See changes: symfony/swiftmailer-bundle@v2.3.8...v2.3.9
   Release notes: https://github.com/symfony/swiftmailer-bundle/releases/tag/v2.3.9

 - symfony/monolog-bundle updated from 2.8.1 to v2.8.2
   See changes: symfony/monolog-bundle@2.8.1...v2.8.2
   Release notes: https://github.com/symfony/monolog-bundle/releases/tag/v2.8.2

 - sensio/distribution-bundle updated from v3.0.33 to v3.0.34
   See changes: sensiolabs/SensioDistributionBundle@v3.0.33...v3.0.34
   Release notes: https://github.com/sensiolabs/SensioDistributionBundle/releases/tag/v3.0.34

 - friendsofsymfony/rest-bundle updated from 1.7.2 to 1.7.4
   See changes: FriendsOfSymfony/FOSRestBundle@1.7.2...1.7.4
   Release notes: https://github.com/FriendsOfSymfony/FOSRestBundle/releases/tag/1.7.4

 - nelmio/api-doc-bundle updated from 2.10.3 to 2.11.0
   See changes: nelmio/NelmioApiDocBundle@2.10.3...2.11.0
   Release notes: https://github.com/nelmio/NelmioApiDocBundle/releases/tag/2.11.0

 - j0k3r/graby-site-config updated from 1.0.6 to 1.0.9
   See changes: j0k3r/graby-site-config@1.0.6...1.0.9
   Release notes: https://github.com/j0k3r/graby-site-config/releases/tag/1.0.9

 - j0k3r/safecurl updated from v1.1.1 to 2.0.2
   See changes: j0k3r/safecurl@v1.1.1...2.0.2
   Release notes: https://github.com/j0k3r/safecurl/releases/tag/2.0.2

 - j0k3r/graby updated from 1.0.4 to 1.0.6
   See changes: j0k3r/graby@1.0.4...1.0.6
   Release notes: https://github.com/j0k3r/graby/releases/tag/1.0.6

 - scheb/two-factor-bundle updated from v1.4.7 to v1.5.0
   See changes: scheb/two-factor-bundle@v1.4.7...v1.5.0
   Release notes: https://github.com/scheb/two-factor-bundle/releases/tag/v1.5.0

 - sebastian/recursion-context updated from 1.0.1 to 1.0.2
   See changes: sebastianbergmann/recursion-context@1.0.1...1.0.2
   Release notes: https://github.com/sebastianbergmann/recursion-context/releases/tag/1.0.2

 - sebastian/environment updated from 1.3.2 to 1.3.3
   See changes: sebastianbergmann/environment@1.3.2...1.3.3
   Release notes: https://github.com/sebastianbergmann/environment/releases/tag/1.3.3

 - sebastian/diff updated from 1.3.0 to 1.4.0
   See changes: sebastianbergmann/diff@1.3.0...1.4.0
   Release notes: https://github.com/sebastianbergmann/diff/releases/tag/1.4.0

 - phpunit/phpunit updated from 4.8.18 to 4.8.19
   See changes: sebastianbergmann/phpunit@4.8.18...4.8.19
   Release notes: https://github.com/sebastianbergmann/phpunit/releases/tag/4.8.19

 - symfony/phpunit-bridge updated from v2.7.7 to v2.8.0
   See changes: symfony/phpunit-bridge@v2.7.7...v2.8.0
   Release notes: https://github.com/symfony/phpunit-bridge/releases/tag/v2.8.0

 - doctrine/doctrine-cache-bundle updated from 1.2.1 to 1.2.2
   See changes: doctrine/DoctrineCacheBundle@1.2.1...1.2.2
   Release notes: https://github.com/doctrine/DoctrineCacheBundle/releases/tag/1.2.2

 - doctrine/doctrine-bundle updated from v1.5.2 to 1.6.1
   See changes: doctrine/DoctrineBundle@v1.5.2...1.6.1
   Release notes: https://github.com/doctrine/DoctrineBundle/releases/tag/1.6.1

 - phpzip/phpzip updated from 2.0.7 to 2.0.8
   See changes: Grandt/PHPZip@2.0.7...2.0.8
   Release notes: https://github.com/Grandt/PHPZip/releases/tag/2.0.8

 - kphoen/rulerz updated from 0.14.0 to 0.16.1
   See changes: K-Phoen/rulerz@0.14.0...0.16.1
   Release notes: https://github.com/K-Phoen/rulerz/releases/tag/0.16.1

 - friendsofsymfony/user-bundle updated from dev-master to dev-master
   See changes: FriendsOfSymfony/FOSUserBundle@45d6f40...e39b040
@j0k3r
Remove weak deprecation 💥
30a40b0
@j0k3r
Wallabag now require PHP >= 5.5
bd2c8b4 
See https://github.com/K-Phoen/rulerz/pull/21/files#diff-b5d0ee8c97c7abd7e3fa29b9a27d1780
@j0k3r
Improve composer.json
516022d 
Following great article from Jordi: http://seld.be/notes/new-composer-patterns

Changelogs summary:

 - paragonie/random_compat updated from 1.1.1 to 1.1.4
   See changes: paragonie/random_compat@1.1.1...1.1.4
   Release notes: https://github.com/paragonie/random_compat/releases/tag/1.1.4

 - doctrine/cache updated from v1.5.2 to v1.5.4
   See changes: doctrine/cache@v1.5.2...v1.5.4
   Release notes: https://github.com/doctrine/cache/releases/tag/v1.5.4

 - sensio/framework-extra-bundle updated from v3.0.11 to v3.0.12
   See changes: sensiolabs/SensioFrameworkExtraBundle@v3.0.11...v3.0.12
   Release notes: https://github.com/sensiolabs/SensioFrameworkExtraBundle/releases/tag/v3.0.12

 - nelmio/cors-bundle updated from 1.4.0 to 1.4.1
   See changes: nelmio/NelmioCorsBundle@1.4.0...1.4.1
   Release notes: https://github.com/nelmio/NelmioCorsBundle/releases/tag/1.4.1

 - friendsofsymfony/rest-bundle updated from 1.7.4 to 1.7.6
   See changes: FriendsOfSymfony/FOSRestBundle@1.7.4...1.7.6
   Release notes: https://github.com/FriendsOfSymfony/FOSRestBundle/releases/tag/1.7.6

 - nelmio/api-doc-bundle updated from 2.11.0 to 2.11.1
   See changes: nelmio/NelmioApiDocBundle@2.11.0...2.11.1
   Release notes: https://github.com/nelmio/NelmioApiDocBundle/releases/tag/2.11.1

 - neitanod/forceutf8 updated from v1.5 to v2.0
   See changes: neitanod/forceutf8@v1.5...v2.0
   Release notes: https://github.com/neitanod/forceutf8/releases/tag/v2.0

 - j0k3r/graby-site-config updated from 1.0.9 to 1.0.10
   See changes: j0k3r/graby-site-config@1.0.9...1.0.10
   Release notes: https://github.com/j0k3r/graby-site-config/releases/tag/1.0.10

 - j0k3r/graby updated from 1.0.6 to 1.0.7
   See changes: j0k3r/graby@1.0.6...1.0.7
   Release notes: https://github.com/j0k3r/graby/releases/tag/1.0.7

 - sebastian/diff updated from 1.4.0 to 1.4.1
   See changes: sebastianbergmann/diff@1.4.0...1.4.1
   Release notes: https://github.com/sebastianbergmann/diff/releases/tag/1.4.1

 - phpunit/phpunit updated from 4.8.19 to 4.8.21
   See changes: sebastianbergmann/phpunit@4.8.19...4.8.21
   Release notes: https://github.com/sebastianbergmann/phpunit/releases/tag/4.8.21

 - kphoen/rulerz updated from 0.16.1 to 0.16.2
   See changes: K-Phoen/rulerz@0.16.1...0.16.2
   Release notes: https://github.com/K-Phoen/rulerz/releases/tag/0.16.2
@j0k3r
Symfony Upgrade Fixer FTW
619cc45 
symfony-upgrade-fixer fix src/Wallabag/
@j0k3r
Update bundle & stock file
5c895a7 
- update stock file (AppKernel, app.php, etc ..) from SymfonyStandard edition)
- update bundle to latest release
- remove security on profiler
@j0k3r
Switch to psr-4
b4faefc
@j0k3r
TwoFactorBundle -> 2.0
8ba854c
@j0k3r
Fix recent update
1d76102 
- some missing url parameters from WallabagRestController & EntryController
- use a service for `EntryFilterType` to use fully qualified name instead (so changing class signature)
- update ImportBundle (url & form)
@j0k3r
Update deps
6108b0f 
LexikFormFilterBundle & RulerZBundle are now Symfony 3 compatible

There are still some issue with FOSOAuthServerBundle
@j0k3r
Fix Pocket generateUrl parameters
27e475a
@j0k3r
Update to friendsofsymfony/oauth-server-bundle@1.5.0-BETA
c38d27d
@j0k3r
Remove some commented code
1d405d0
@j0k3r
Switch to Symfony 3 structure
73cd160
@j0k3r
Update to Symfony 3.0.x
31e33fc
@j0k3r
Update path in build file
ccf50a9
@j0k3r
Add assets config
d8dbe76 
To avoid :
> Twig_Error_Syntax: Unknown "asset" function in
@j0k3r
Last deps update
1fc8ed8
@j0k3r
Update readme & fix console permission
c7f622d
nicosomb added a commit that referenced this pull request Jan 15, 2016
@nicosomb
Merge pull request #1524 from wallabag/sf2.8
1930c19 
Upgrade to Symfony 3.0
@nicosomb nicosomb merged commit 1930c19 into v2 Jan 15, 2016
@nicosomb nicosomb deleted the sf2.8 branch January 15, 2016 14:38
@j0k3r
Copy link
Member Author

j0k3r commented Jan 15, 2016

🎉 💥

@nicosomb
Copy link
Member

🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Ready for review
Projects
None yet
Milestone
2.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@j0k3r @nicosomb