Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed table name for tagging rule #1529

Merged
merged 2 commits into from
Dec 8, 2015
Merged

changed table name for tagging rule #1529

merged 2 commits into from
Dec 8, 2015

Conversation

nicosomb
Copy link
Member

@nicosomb nicosomb commented Dec 8, 2015

ping @K-Phoen

@nicosomb nicosomb added this to the 2.0.0-alpha.1 milestone Dec 8, 2015
@j0k3r
Copy link
Member

j0k3r commented Dec 8, 2015

What was the generated name before that change?

@nicosomb
Copy link
Member Author

nicosomb commented Dec 8, 2015

wallabag_TaggingRule

@j0k3r
Copy link
Member

j0k3r commented Dec 8, 2015

What is the generated name for the tag user table? Is it tag_user? If yes, we should name that table tagging_rule instead.

@nicosomb
Copy link
Member Author

nicosomb commented Dec 8, 2015

wallabag_tag, wallabag_entry_tag, etc.

You're right, I fix it.

j0k3r added a commit that referenced this pull request Dec 8, 2015
@j0k3r
Merge pull request #1529 from wallabag/v2-taggingrule-tablename
da2240f 
changed table name for tagging rule
@j0k3r j0k3r merged commit da2240f into v2 Dec 8, 2015
@j0k3r j0k3r deleted the v2-taggingrule-tablename branch December 8, 2015 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@j0k3r j0k3r

Labels
None yet
Projects
None yet
Milestone
2.0.0-alpha.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicosomb @j0k3r