Settings page #1612
Merged
Settings page #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -58,3 +58,4 @@ security: | |||
| - { path: ^/resetting, role: IS_AUTHENTICATED_ANONYMOUSLY } | |||
| - { path: /(unread|starred|archive).xml$, roles: IS_AUTHENTICATED_ANONYMOUSLY } | |||
| - { path: ^/, roles: ROLE_USER } | |||
| - { path: ^/settings, roles: ROLE_SUPER_ADMIN } | |||
There was a problem hiding this comment.
With my ROLE_USER user, I can access to this URL.
There was a problem hiding this comment.
Oh yeah I haven't tested that case. It's done.
j0k3r
force-pushed
the
v2-settings-page
branch
from
90c4dfd
to
c9c6aef
Compare
| @@ -41,25 +47,6 @@ wallabag_import: | |||
| twig: | |||
| debug: "%kernel.debug%" | |||
| strict_variables: "%kernel.debug%" | |||
| globals: | |||
|
Still conflicts due to the last merged PR. |
j0k3r
force-pushed
the
v2-settings-page
branch
from
dbbb20c
to
58a772a
Compare
|
Don't forget to update parameters according to #1629. :) |
These default configuration value shouldn't be in parameters.yml.
We'll remove it later, on the stable release
Warn user if pocket_consumer_key isn't defined
j0k3r
force-pushed
the
v2-settings-page
branch
from
58a772a
to
48e3007
Compare
|
@tcitworld updated. |
|
You deleted the |
|
@tcitworld It's sent to the template here and I don't have to update the template because the |
| export_txt: Activer l'export TXT | ||
| export_xml: Activer l'export XML | ||
| pocket_consumer_key: Clé d'authentification Pocket pour importer les données (https://getpocket.com/developer/docs/authentication) | ||
| shaarli_url: URL de Shaarli, si le service Diaspora est activé |
There was a problem hiding this comment.
si le service Diaspora est activé > si le service est activé
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1575
This PR add an internal config page where admin can configure its wallabag instance. Most of the parameters from the
parameters.yml.distwere moved to this page as they can be switched during run time.To achieve that I've used the CraueConfigBundle. Each parameter has a section which allow to have a less disgusting internal config page.
This page is only accessible by user with role
ROLE_SUPER_ADMIN.This table is filled using the InstallCommand (at the same time we build the user config).
Things to check before validate this PR:
Preview:
Bonus
I've added a message on the Pocket import page when the consumer key isn't defined: