Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 annotator comments #1653

Merged
merged 7 commits into from
Feb 26, 2016
Merged

V2 annotator comments #1653

merged 7 commits into from
Feb 26, 2016

Conversation

tcitworld
Copy link
Member

  • post comment
  • read comments for an entry
  • edit comment
  • delete comment
  • tests
  • Bring annotator to baggy
  • little documentation

For 2.0 stable :

  • API stuff

For 2.1 :

  • Dealing with multiple users and all this stuff

Fix #994

@tcitworld tcitworld added this to the 2.0.0 milestone Feb 7, 2016
@tcitworld tcitworld assigned tcitworld and unassigned tcitworld Feb 7, 2016
@tcitworld tcitworld mentioned this pull request Feb 9, 2016
Closed
@tcitworld
Copy link
Member Author

Okay, the edit and delete functions are very discreet.

nicosomb
nicosomb reviewed Feb 15, 2016
View reviewed changes
app/config/routing_rest.yml
@@ -1,3 +1,3 @@
Rest_Wallabag:
type : rest
resource: "@WallabagApiBundle/Resources/config/routing_rest.yml"
resource: "@WallabagApiBundle/Resources/config/routing_rest.yml"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you install editorconfig plugin on your favorite IDE please? ;-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it is. Strange.

@j0k3r
Copy link
Member

j0k3r commented Feb 15, 2016

Do you have an idea on why the default called url when opening an article contains a parameter with entry id: /annotations/7?entry=7 ?

@tcitworld
Copy link
Member Author

I added https://github.com/wallabag/wallabag/pull/1653/files#diff-2c1424825ef3119eace5cdec44e06b10R153 but it may not be needed and therefore causing this.

@j0k3r
Copy link
Member

j0k3r commented Feb 15, 2016

Yep we don't need that

@j0k3r
Copy link
Member

j0k3r commented Feb 15, 2016

BTW, if we don't merge that for the first beta we'll need to generate a Doctrine migration class

@j0k3r
Copy link
Member

j0k3r commented Feb 18, 2016

What about returning comments in the entry api ?

tcitworld
tcitworld reviewed Feb 23, 2016
View reviewed changes
src/Wallabag/CommentBundle/Resources/config/services.yml
@@ -0,0 +1,4 @@
services:
# wallabag_comment.example:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. Generated automatically.

@tcitworld tcitworld mentioned this pull request Feb 24, 2016
Closed
@j0k3r j0k3r mentioned this pull request Feb 24, 2016
Closed
@j0k3r
Copy link
Member

j0k3r commented Feb 24, 2016

Before merging that, @nicosomb are you ok if we name annotation in french?

@nicosomb
Copy link
Member

👍

@j0k3r j0k3r self-assigned this Feb 24, 2016
@nicosomb nicosomb modified the milestones: 2.0.0-beta.1, 2.0.0 Feb 26, 2016
@nicosomb
Copy link
Member

@tcitworld As I replaced idComment with idAnnotation, I think that we need to fix that: wallabag/annotator@bf1befd Right?

j0k3r
j0k3r reviewed Feb 26, 2016
View reviewed changes
src/Wallabag/AnnotationBundle/DependencyInjection/WallabagCommentExtension.php
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\HttpKernel\DependencyInjection\Extension;

class WallabagCommentExtension extends Extension
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be WallabagAnnotationExtension

@tcitworld
Copy link
Member Author

Yup, you need to.

@j0k3r
Copy link
Member

j0k3r commented Feb 26, 2016

And voilà, everything is cleanup.

nicosomb added a commit that referenced this pull request Feb 26, 2016
@nicosomb
Merge pull request #1653 from wallabag/v2-annotator-comments
1629547 
V2 annotator comments
@nicosomb nicosomb merged commit 1629547 into v2 Feb 26, 2016
@j0k3r j0k3r deleted the v2-annotator-comments branch February 26, 2016 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@j0k3r j0k3r

Labels
Ready for review
Projects
None yet
Milestone
2.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tcitworld @j0k3r @nicosomb @0wnrepo