import tags from v1 (#1657) #1658
Conversation
| if ($importedEntry['tags'] != '') { | ||
| $tags = explode(',', $importedEntry['tags']); | ||
| foreach ($tags as $tagv1) { | ||
| $tag = new Tag(); |
There was a problem hiding this comment.
You should check if tag exist first. See https://github.com/wallabag/wallabag/blob/v2/src/Wallabag/ImportBundle/Import/PocketImport.php#L180
Todo: We need this method to be called from (almost) everywhere since we already use it in ContentProxy.
There was a problem hiding this comment.
Todo: We need this method to be called from (almost) everywhere since we already use it in ContentProxy.
assignTagsToEntry ?
There was a problem hiding this comment.
Yeah. I once set a todo but I guess @nicosomb removed it
tcitworld
force-pushed
the
v2-import-v1-tags
branch
from
1f3f493
to
cb2c3ee
Compare
|
Yeah we might need one more test in You should retrieve with that url |
tcitworld
force-pushed
the
v2-import-v1-tags
branch
from
9b44032
to
2e63554
Compare
| $tag = $client->getContainer() | ||
| ->get('doctrine.orm.entity_manager') | ||
| ->getRepository('WallabagCoreBundle:Tag') | ||
| ->findOneByTagLabel('Framabag'); |
There was a problem hiding this comment.
Could you try with findOneByLabel instead ? I guess this magic method exist
tcitworld
force-pushed
the
v2-import-v1-tags
branch
from
2e63554
to
fca2b05
Compare
|
Great ! 👍 |
#1657
Maybe a few more tests ?