reimport v1 entries if they were not fetched #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -123,6 +126,10 @@ public function setFilepath($filepath) | |||
| protected function parseEntries($entries) | |||
| { | |||
| $i = 1; | |||
| /* | |||
| * Untitled in all languages from v1. This should never have been translated | |||
| */ | |||
There was a problem hiding this comment.
You can put the comment on one line starting with //
You can add both for the v1 & v2 import file |
|
👍 |
j0k3r
added a commit
that referenced
this pull request
Feb 11, 2016
…-fetched reimport v1 entries if they were not fetched
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an article was not properly fetched on v1, this will reimport it.
About tests, does adding a untitled entry in wallabag-v1.json is enough ?