Mark all imported articles as read #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! |
|
It doesn't do Pocket, but I assume it's normal. |
|
Good idea !
|
|
How can the tests to be sure the inserted articles are really archived for v2 & Pocket be made ? |
|
It can't. Or at least, you need to check before the import that the article is not archived and check after the import. |
By parsing the json file inside the test once before ? |
tcitworld
force-pushed
the
v2-mark-imported-articles-as-read
branch
from
35d8f6b
to
2b27504
Compare
|
Or just by knowing that an url will be imported |
|
@tcitworld It seems that your PR has tests. What is your todo list here? |
|
@tcitworld poke |
|
Yeah, I'll need a little help on that. ;-) |
|
Excellent, what kind of help? |
j0k3r
force-pushed
the
v2-mark-imported-articles-as-read
branch
from
2b27504
to
f8c90af
Compare
j0k3r
force-pushed
the
v2-mark-imported-articles-as-read
branch
from
f8c90af
to
c32ae32
Compare
Reformat json file (thanks pro.jsonlint.com)
nicosomb
added a commit
that referenced
this pull request
Mar 4, 2016
Mark all imported articles as read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #870