Fix #1551 - Redirect to the last page when current page is out of range #1700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
delyriand
commented
Feb 19, 2016
delyriand
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Documentation | no |
| Translation | no |
| Fixed tickets | #1551 |
| License | MIT |
| $entries->setCurrentPage($page); | ||
| } catch (OutOfRangeCurrentPageException $e) { | ||
| if ($page > 1) { | ||
| return $this->redirect(str_replace('/' . $page, '/' . $entries->getNbPages(), $request->getRequestUri()), 301); |
There was a problem hiding this comment.
I'll rather do:
return $this->redirect($this->generateUrl($type, array('page' => $entries->getNbPages())));There was a problem hiding this comment.
I agree with you!
delyriand
force-pushed
the
v2-fix-1551
branch
2 times, most recently
from
97e8010
to
4d85a87
Compare
| $entries->setCurrentPage($page); | ||
| } catch (OutOfRangeCurrentPageException $e) { | ||
| if ($page > 1) { | ||
| return $this->redirect($this->generateUrl($type, array('page' => $entries->getNbPages())), 301); |
There was a problem hiding this comment.
Also, could you put a 302 instead? You don't know if in the future you'll have the given page :)
There was a problem hiding this comment.
indeed ... in my mind, I wanted to make a temporary redirect :)
delyriand
force-pushed
the
v2-fix-1551
branch
from
4d85a87
to
671a2b8
Compare
|
Thanks ! 👍 |
j0k3r
added a commit
that referenced
this pull request
Feb 19, 2016
Fix #1551 - Redirect to the last page when current page is out of range
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.