Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare files for 2.0.0-beta.2 #1763

Merged
merged 5 commits into from
Mar 11, 2016
Merged

Prepare files for 2.0.0-beta.2 #1763

merged 5 commits into from
Mar 11, 2016

Conversation

nicosomb
Copy link
Member

@nicosomb nicosomb commented Mar 8, 2016

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documentation yes
Translation yes
Fixed tickets N/A
License MIT

Because we have problems for those who install wallabag via composer create-project (no way to upgrade their installation), we considered to use git clone.

git clone git@github.com:wallabag/wallabag.git
cd wallabag
git checkout 2.0.0-beta.2
SYMFONY_ENV=prod composer install --no-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add -o at the end? It'll optimize the autoload.

@nicosomb nicosomb modified the milestone: 2.0.0-beta.2 Mar 8, 2016
@nicosomb
Copy link
Member Author

nicosomb commented Mar 8, 2016

With this new installation, the user needs to generate a new github token.
@wallabag/core do you know if we can avoid this behavior?

(thank you @chris25640 for your tests)

@nicosomb
Copy link
Member Author

Finally back to composer create-project with --keep-vcs option.

j0k3r added a commit that referenced this pull request Mar 11, 2016
@j0k3r j0k3r merged commit 6aed6d6 into v2 Mar 11, 2016
@j0k3r j0k3r deleted the v2-prepare-beta2 branch March 11, 2016 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants