Setting for reading time #1767
Merged
Setting for reading time #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Relaunched the Travis task that failed to clear cache for some reason. |
| @@ -29,6 +29,9 @@ public function getConfigTreeBuilder() | |||
| ->integerNode('rss_limit') | |||
| ->defaultValue(50) | |||
| ->end() | |||
| ->integerNode('reading_speed') | |||
| ->defaultValue(200) | |||
There was a problem hiding this comment.
Will fix. I didn't fix some tests.
nicosomb
force-pushed
the
v2-setting-for-reading-time
branch
from
bd0483f
to
91bcc92
Compare
nicosomb
force-pushed
the
v2-setting-for-reading-time
branch
from
91bcc92
to
6432b92
Compare
|
I removed the slider to put a list. More readable.
|
| Reading speed | ||
| ~~~~~~~~~~~~~ | ||
|
|
||
| wallabag calculates a reading time for each article. You can define here, thanks to the slider, if you are |
|
Just improved tests ... |
|
I'm ok with that PR. |
| @@ -248,6 +255,30 @@ public function getRssLimit() | |||
| } | |||
|
|
|||
| /** | |||
| * Set readingSpeed. | |||
| * | |||
| * @param int $readingSpeed | |||
There was a problem hiding this comment.
This should be float right? (same for the getReadingSpeed)
nicosomb
force-pushed
the
v2-setting-for-reading-time
branch
from
ee57dcf
to
1b64a84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a setting in config screen to define the reading speed for each user (I read so fast, I read so slowly, etc.)
TODO :