Force user-agent for iansommerville.com #1804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the default User Agent, the website returns a 403. By forcing the User Agent for this domain, we got the proper behavior: a 200 Since we can't _append_ new user agent to the default graby configuration, we need to rewrite all the default config + the new one. Fix #1801
| error_message: "wallabag can't retrieve contents for this article. Please report this issue to us." | ||
| http_client: | ||
| user_agents: | ||
| 'lifehacker.com': 'PHP/5.2' |
There was a problem hiding this comment.
We'll have a huge file in next weeks?
There was a problem hiding this comment.
Next weeks?
We don't update that list quite often.
But I agree that this isn't greatly designed in graby (inherited from full-text-rss on that part)
|
@wallabag/core Do we need to try to move this fix in graby or can I merge? |
|
This'll require too much work on graby. You can merge that and we'll see later when (if ?) graby evolve, we'll update the code accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the default User Agent, the website returns a 403. By forcing the User Agent for this domain, we got the proper behavior: a 200
Since we can't append new user agent to the default graby configuration, we need to rewrite all the default config + the new one.