Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation fa #1823

Merged
merged 2 commits into from Apr 10, 2016
Merged

Translation fa #1823

merged 2 commits into from Apr 10, 2016

Conversation

mabkenar
Copy link

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documentation no
Translation yes
Fixed tickets comma-separated list of tickets fixed by the PR, if any
License MIT

# email: 'By email'
# gitter: 'On Gitter'
page_title: 'Quickstart'
intro:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation problem here, you should have 8 spaces.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see. Maybe when I was manually deleting comments to make translations, I should have deleted the extra space after the '#' character.
Is it only the red part above that needs to be fixed, or is it everywhere in the file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just this whole paragraph

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation problem is still here.
You should add 3 spaces to the whole quickstart section, except for the page_title

@nicosomb nicosomb modified the milestone: 2.0.0 Mar 29, 2016
# email: 'By email'
# gitter: 'On Gitter'
page_title: 'Quickstart'
intro:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, it should have 4 spaces 😕 Sorry.

@j0k3r
Copy link
Member

j0k3r commented Mar 29, 2016

Ok we'll do in an other way.
Could you translate the developer part? I'll fix indentation after merging your PR 😉

@j0k3r
Copy link
Member

j0k3r commented Apr 10, 2016

@mabkenar I've fixed indentation. Feel free to provide an other PR to translate missing translations.
Thanks !

@nicosomb nicosomb merged commit 15e9483 into v2 Apr 10, 2016
@nicosomb nicosomb deleted the translation-fa branch April 10, 2016 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants