New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation fa #1823
Translation fa #1823
Conversation
mabkenar
commented
Mar 29, 2016
Q | A |
---|---|
Bug fix? | no |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Tests pass? | yes |
Documentation | no |
Translation | yes |
Fixed tickets | comma-separated list of tickets fixed by the PR, if any |
License | MIT |
# email: 'By email' | ||
# gitter: 'On Gitter' | ||
page_title: 'Quickstart' | ||
intro: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation problem here, you should have 8 spaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see. Maybe when I was manually deleting comments to make translations, I should have deleted the extra space after the '#' character.
Is it only the red part above that needs to be fixed, or is it everywhere in the file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just this whole paragraph
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation problem is still here.
You should add 3 spaces to the whole quickstart section, except for the page_title
# email: 'By email' | ||
# gitter: 'On Gitter' | ||
page_title: 'Quickstart' | ||
intro: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, it should have 4 spaces 😕 Sorry.
Ok we'll do in an other way. |
@mabkenar I've fixed indentation. Feel free to provide an other PR to translate missing translations. |