Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Occitan version #1829

Merged
merged 6 commits into from
Apr 1, 2016
Merged

Occitan version #1829

merged 6 commits into from
Apr 1, 2016

Conversation

Quent-in
Copy link
Contributor

@Quent-in Quent-in commented Apr 1, 2016

Q A
Translation yes
Fixed tickets comma-separated list of tickets fixed by the PR, if any
License MIT

I hope everything is fine now! Looking forward to seeing it running :)

rss: 'RSS'
user_info: 'Mon compte'
password: 'Senhal'
rules: 'Règlas d\'etiquetas automaticas'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should remove simple quote around and put double quote:

rules: "Règlas d'etiquetas automaticas"

It also apply to the 3 others occurence in this file. You should fix them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the d\' part, and put the string into double quotes : "Règlas d'etiquetas automaticas"

@Quent-in
Copy link
Contributor Author

Quent-in commented Apr 1, 2016

Is it ok now?

@j0k3r
Copy link
Member

j0k3r commented Apr 1, 2016

You should update your file and push changes on the same branch not by creating a new one :)

@Quent-in
Copy link
Contributor Author

Quent-in commented Apr 1, 2016

I pushed "edit" I didnt except it would creat something else. Can do it for me, I start to lose temper with GitHub logic :(

@j0k3r j0k3r merged commit cb68c76 into wallabag:v2 Apr 1, 2016
@j0k3r
Copy link
Member

j0k3r commented Apr 1, 2016

So I fixed bugs manually here 1695a6f
Thanks for that contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants