馃殌 Prepare v2.0.0 馃巶 #1835
馃殌 Prepare v2.0.0 馃巶 #1835
Conversation
| @@ -8,8 +8,7 @@ Click, save and read it when you can. It extracts content so that you can read i | |||
|
|
|||
| More informations on our website: [wallabag.org](https://wallabag.org) | |||
|
|
|||
| # Want to test the v2? | |||
| Keep in mind it's an **unstable** branch, everything can be broken :) | |||
| # Installa wallabag | |||
There was a problem hiding this comment.
Typo here.
Do you mean "Install wallabag" or "Install a wallabag"?
There was a problem hiding this comment.
install wallabag ;-)
Thank you, will fix.
| @@ -70,10 +70,6 @@ | |||
|
|
|||
| {% block footer %}{% endblock %} | |||
|
|
|||
| <div id="warning_message"> | |||
There was a problem hiding this comment.
Can you remove the associated css too ?
There was a problem hiding this comment.
Could we instead keep the div and activate the message through parameters ?
There was a problem hiding this comment.
It was a parameter before :)
There was a problem hiding this comment.
That's what I thought. How come we changed it ?
There was a problem hiding this comment.
This can be moved to the config_prod.yml file and should be disabled in the config_dev.yml.
I don鈥檛 like this message in dev :)
And yep it was in the parameters.yml before, but I don鈥檛 think it should be a param that must be defined by the end user when it install wallabag.
There was a problem hiding this comment.
(In the future, at least)
We'll add the <div>. I'm not fan of the "and if ever...". If we'll need it, we'll add it.
There was a problem hiding this comment.
I don鈥檛 like this message in dev :)
Yup, it hides things, especially in mobile view. TODO for next release.
馃巶 馃巶 馃巶