Improve pagination when user has lot of entries #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #1905 * Usage of whiteoctober/WhiteOctoberPagerfantaBundle
| if ($page > 1) { | ||
| return $this->redirect($this->generateUrl($type, array('page' => $entries->getNbPages())), 302); | ||
| } | ||
| } |
There was a problem hiding this comment.
WhiteOctoberPagerfantaBundle adds this behavior, see https://github.com/whiteoctober/WhiteOctoberPagerfantaBundle#making-bad-page-numbers-return-a-http-500
There was a problem hiding this comment.
But you have to define it right? Because I guess that by default, the bundle doesn't redirect to the latest page?
There was a problem hiding this comment.
You're right.
I thought that our previous behavior was to avoid an Exception. But no, it was really to redirect (#1551).
Will fix that.
| @@ -7,16 +7,9 @@ | |||
| <div class="results"> | |||
| <div class="nb-results">{{ 'entry.list.number_on_the_page'|transchoice(entries.count) }}</div> | |||
| <div class="pagination"> | |||
|
It's really sad that pagerfanta (the lib not the bundle) didn't get any update since 2014 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1905
Usage of https://github.com/whiteoctober/WhiteOctoberPagerfantaBundle
TODO